Bug 1289070 - Review Request: aobook - Aozora Bunko text viewer
Summary: Review Request: aobook - Aozora Bunko text viewer
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2015-12-07 11:36 UTC by Mamoru TASAKA
Modified: 2020-08-10 00:55 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-08-10 00:55:00 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Mamoru TASAKA 2015-12-07 11:36:29 UTC
Spec URL: https://mtasaka.fedorapeople.org/Review_request/aobook/aobook.spec
SRPM URL: https://mtasaka.fedorapeople.org/Review_request/aobook/aobook-1.0.1-1.fc.src.rpm
Description: 
Aozora Bunko text viewer.
Fedora Account System Username: mtasaka

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-01-08 19:49:34 UTC
Can you extend the description to give a hint what this package does and why would one want to install it (over other text viewers)?

Comment 2 Mamoru TASAKA 2016-01-09 09:57:47 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Can you extend the description to give a hint what this package does and why
> would one want to install it (over other text viewers)?

I may do so later. Meanwhile I would appreciate if you would
review other points (or if you have your own review request,
I can do review swap),

Comment 3 Mamoru TASAKA 2016-01-09 10:02:45 UTC
BTW Aozora Bunko is the collection of Japanese copyright-expired books and the explanation of aobook is written all in Japanese, see

http://azsky2.html.xdomain.jp/linux/aobook/

so to extend description translation to Japanese is needed.

Comment 4 Mamoru TASAKA 2016-01-09 10:04:05 UTC
(In reply to Mamoru TASAKA from comment #3)
> BTW Aozora Bunko is the collection of Japanese copyright-expired books and
> the explanation of aobook is written all in Japanese, see
> 
> http://azsky2.html.xdomain.jp/linux/aobook/
> 
> so to extend description translation to Japanese is needed.

of course translation _from_ Japanese...

Comment 5 Zbigniew Jędrzejewski-Szmek 2016-01-09 14:34:49 UTC
One part of the review is checking if the software works. To do that, the reviewer has to know what the software is supposed to be used for. You cannot expect reviewers to do research on a website in Japanese. If you don't feel comfortable translating or writing the stuff yourself, ask for help. Right now you are asking potential reviewers to do the research on their own.

Since this is a graphical app, you should include an appdata file [https://fedoraproject.org/wiki/Packaging:AppData].

Comment 6 Mamoru TASAKA 2016-01-10 15:47:15 UTC
Well, in such sense, checking if this software works needs Japanese knowledge anyway... 

Anyway if you want to try this, for example
- Go to http://www.aozora.gr.jp/cards/000148/card773.html#download
  (Soseki NATSUME "Kokoro"
   https://en.wikipedia.org/wiki/Kokoro )
- Download 773_ruby_5968.zip
- launch aobook *in Japanese locale*, choose 「ファイル」-> 「開く」 and choose the downloaded zip file

Comment 7 Mamoru TASAKA 2016-01-10 15:55:30 UTC
(So perhaps Japanese people who likes reading novels or so perhaps knows about "Aozora bunko", so I guess "Aozora Bunko text viewer" is already enough explanation - on the other hand, I don't think aobook description should include the explanatin of Aozora bunko)

Comment 8 Zbigniew Jędrzejewski-Szmek 2016-01-10 20:31:47 UTC
Based on your answers, I'm guessing that this is a program which:
- can display Japanese novels from Aozora bunko (is this is a specific format?)
- the interface is in Japanese so it is only useful for Japanese speakers (?)

This kind of information should be present in the %description. Please remember that the description is not only used by people for whom the viewer would be useful, but just as often, if not more often, by people who are browsing through a catalogue and need to decide if this piece of software meets their needs and could use the description to decide that they need something else.

You did not respond to my comment about appdata.

Comment 9 Mamoru TASAKA 2016-01-13 15:49:36 UTC
* Appdata is should, not must and I don't make it blocker when I review others.
* I may try updating %description, however I would appreciate if you would point out other points
* And again if any I can offer review swap.

Comment 10 Zbigniew Jędrzejewski-Szmek 2016-01-14 16:31:29 UTC
(In reply to Mamoru TASAKA from comment #9)
> * Appdata is should, not must and I don't make it blocker when I review
> others.
Yes. It's a should. So far I haven't heard any reasons to not provide it. In case of an application for non-technical users like a ebook viewer appdata is particularly useful.

> * I may try updating %description, however I would appreciate if you would
> point out other points
Looks good otherwise.

> * And again if any I can offer review swap.
Thank you. I don't have any outstanding packages, but you can always grab one from http://fedoraproject.org/PackageReviewStatus/NEW.html ;)

Comment 11 Package Review 2020-07-10 00:54:11 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 12 Package Review 2020-08-10 00:55:00 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.