Spec URL: https://gil.fedorapeople.org/apache-commons-weaver.spec SRPM URL: https://gil.fedorapeople.org/apache-commons-weaver-1.1-1.fc23.src.rpm Description: Apache Commons Weaver provides an easy way to enhance compiled Java classes by generating ("weaving") bytecode into those classes. Fedora Account System Username: gil
gil's scratch build of apache-commons-weaver-1.1-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12114229
All *.txt are installed as executable. All summaries are quite weak, they pretty much just repeat the package's name. Most subpackage descriptions have the same issue as the summaries. Are the test failures somehow expected and safe to just ignore? Upstream issue tracker or discussion reference? Javadocs crosslink with online Java SE 6 javadocs. Would be better to crosslink with local java-javadoc. Ditto crosslinking with dependencies' javadocs, at least ant-javadoc and objectweb-asm-javadoc seem to be applicable ones, and there are probably more.
(In reply to Ville Skyttä from comment #2) > All *.txt are installed as executable. Fixed > All summaries are quite weak, they pretty much just repeat the package's > name. > > Most subpackage descriptions have the same issue as the summaries. Tried to fix > Are the test failures somehow expected and safe to just ignore? Upstream > issue tracker or discussion reference? This commons-weaver release use xbean-finder 3.18. In Fedora is available xbean-finder >= 4.3. No discussion about upgrade xbean > Javadocs crosslink with online Java SE 6 javadocs. Would be better to > crosslink with local java-javadoc. Ditto crosslinking with dependencies' > javadocs, at least ant-javadoc and objectweb-asm-javadoc seem to be > applicable ones, and there are probably more. Sorry, where you see the for "docs" task crosslink references in commons-weaver project? Spec URL: https://gil.fedorapeople.org/apache-commons-weaver.spec SRPM URL: https://gil.fedorapeople.org/apache-commons-weaver-1.1-2.fc23.src.rpm - fix *.txt permissions
Summaries have not been changed, the issue persists (non-blocker). Descriptions could use a bit longer lines, see other packages (non-blocker). Test stuff is a blocker. First, now there is some kind of an explanation for the FinderTest failure, but there's no explanation why it is fine to just disable the test; the failure seems to be directly related to the xbean-finder dependency changes made in the package. Either the code needs to be fixed so that the test passes, or the test fixed if it's that and not the code that is broken after the change. Can't simply change the dep and ignore errors resulting from doing so. Second, on a quick look, CleanProcessorTest and WeaveProcessorTest failures do not seem to have anything to do with the xbean stuff, so there's still no explanation for why it would be ok to ignore the failures. Regarding crosslinking, I'm just looking at the contents of the -javadoc package; there are various links in them to the online Java SE 6 javadoc. For local crosslinking, adding build deps on related *-javadoc packages and then pointing the javadoc plugin to appropriate local file:///usr/share/javadoc/* dirs would fix it, I imagine (at least it was something like that back when I last had anything to do with Java packaging). https://maven.apache.org/plugins/maven-javadoc-plugin/examples/links-configuration.html (non-blocker as I don't think there is a requirement to do this, but I do recommend fixing it as it should be quite easy) The following subpackages seem to be missing license files: example, normalizer, normalizer-example, privilizer-api
gil's scratch build of apache-commons-weaver-1.2-0.1.RC1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12418510
gil's scratch build of apache-commons-weaver-1.2-0.1.RC1.fc23.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12418655
gil's scratch build of apache-commons-weaver-1.2-0.1.RC1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12419124
Spec URL: https://gil.fedorapeople.org/apache-commons-weaver.spec SRPM URL: https://gil.fedorapeople.org/apache-commons-weaver-1.2-0.1.RC1.fc23.src.rpm - update to 1.2_RC1
(In reply to Ville Skyttä from comment #4) > Test stuff is a blocker. First, now there is some kind of an explanation for > the FinderTest failure, but there's no explanation why it is fine to just > disable the test; the failure seems to be directly related to the > xbean-finder dependency changes made in the package. Either the code needs > to be fixed so that the test passes, or the test fixed if it's that and not > the code that is broken after the change. Can't simply change the dep and > ignore errors resulting from doing so. > > Second, on a quick look, CleanProcessorTest and WeaveProcessorTest failures > do not seem to have anything to do with the xbean stuff, so there's still no > explanation for why it would be ok to ignore the failures. Seem relate to JDK platform vendor. I'm waiting for some news related https://issues.apache.org/jira/browse/WEAVER-10. This kind of issues usually happen and should not considering as blocker, IMO. > Regarding crosslinking, I'm just looking at the contents of the -javadoc > package; there are various links in them to the online Java SE 6 javadoc. > For local crosslinking, adding build deps on related *-javadoc packages and > then pointing the javadoc plugin to appropriate local > file:///usr/share/javadoc/* dirs would fix it, I imagine (at least it was > something like that back when I last had anything to do with Java > packaging). > https://maven.apache.org/plugins/maven-javadoc-plugin/examples/links- > configuration.html (non-blocker as I don't think there is a requirement to > do this, but I do recommend fixing it as it should be quite easy) Done > The following subpackages seem to be missing license files: example, > normalizer, normalizer-example, privilizer-api Done
I'm not at all convinced that it's related to the JDK platform vendor. Our OpenJDK also reports itself as "vendor: Oracle Corporation" so it might be pretty much the same as the one upstream is using. You did not tell upstream that you've changed xbean-finder-shaded to xbean-finder and org.apache.xbean.asm5 to org.objectweb.asm. That is crucial information. I hacked your SRPM so that it does not do those changes and instead downloads xbean-finder-shaded from the network and uses it during the build, and all tests pass. So the failures are related to that change. I don't agree with you that stuff like this is not a blocker. It is quite clear that the package does not work properly at the moment. Because the failures are in the processor component which is quite central to this one and it would not make sense to try shipping the package without it, I don't think this package should be shipped at all before the issues are resolved.
Spec URL: https://gil.fedorapeople.org/apache-commons-weaver.spec SRPM URL: https://gil.fedorapeople.org/apache-commons-weaver-1.2-1.fc23.src.rpm - update to 1.2
I see the upstream issue report has not yet been amended with information that the failures are caused by swap of the xbean stuff. Do you plan to let them know and ask for help, or what's the plan with getting these things fixed?
(In reply to Ville Skyttä from comment #12) > I see the upstream issue report has not yet been amended with information > that the failures are caused by swap of the xbean stuff. Do you plan to let > them know and ask for help, or what's the plan with getting these things > fixed? I do not think they care a lot about our packaging policy. I think for now we must try to solve the problem only for Fedora. I do not know how long we will need to solve it, since xbean is a package not maintained by me. an update could only worsen the situation.
Spec URL: https://gil.fedorapeople.org/apache-commons-weaver.spec SRPM URL: https://gil.fedorapeople.org/apache-commons-weaver-1.2-1.fc23.src.rpm - resolve tests failures Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14043942
Looks like previous revisions of the package have been removed, the latest has been somehow updated today without a trace in %changelog and without the release bumped and the previous 1.2-1 has been overwritten at gil.fedorapeople.org. Also the upstream bug report (link in comment 9) gives a hint that maybe this package has changed to use a bundled library or something, but there's no bundled(...) Provides in the specfile. I would have wanted to check the recent changes to the package to see the reasoning and effect behind them -- especially because the %changelog or comments here don't shed light on them. But that's not possible without the old revisions, so continuing the review would practically mean starting from scratch for me. This combined with the fact that I don't actually have use for this package makes the whole shebang more than what I want to spend time on, so I'll bow out and let someone else -- hopefully one who'll be using the package -- finish the review.
(In reply to Ville Skyttä from comment #15) > Looks like previous revisions of the package have been removed, the latest > has been somehow updated today without a trace in %changelog and without the > release bumped and the previous 1.2-1 has been overwritten at > gil.fedorapeople.org. Also the upstream bug report (link in comment 9) gives > a hint that maybe this package has changed to use a bundled library or > something, but there's no bundled(...) Provides in the specfile. The package contains no library - bundle (...) -. The only significant change is in dependencies used to be able to operate: org.apache.xbean:xbean-asm-util. which contains only the class EmptyVisitor and "extends" only org.objectweb.asm.ClassVisitor and is NOT org.objectweb.asm.commons.EmptyVisitor > I would have wanted to check the recent changes to the package to see the > reasoning and effect behind them -- especially because the %changelog or > comments here don't shed light on them. But that's not possible without the > old revisions, so continuing the review would practically mean starting from > scratch for me. Is NOT necessary, this package use xbean-finder-shaded which contains: xbean-asm-util org.ow2.asm:asm org.ow2.asm:asm-commons but in our xbean package, have not been "masked" > This combined with the fact that I don't actually have use for this package > makes the whole shebang more than what I want to spend time on, so I'll bow > out and let someone else -- hopefully one who'll be using the package -- > finish the review. I don't care, and thanks
references and differences with the original class EmptyVisitor http://grepcode.com/file/repo1.maven.org/maven2/asm/asm-all/3.3.1/org/objectweb/asm/commons/EmptyVisitor.java/
Spec URL: https://gil.fedorapeople.org/apache-commons-weaver.spec SRPM URL: https://gil.fedorapeople.org/apache-commons-weaver-1.3-1.fc24.src.rpm - update to 1.3 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16236826
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.