Bug 1290244
| Summary: | Using ksvalidator -v RHEL6 does not identify "--reserved-percent" as a valid option | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | jcastran |
| Component: | pykickstart | Assignee: | Chris Lumens <clumens> |
| Status: | CLOSED ERRATA | QA Contact: | Release Test Team <release-test-team-automation> |
| Severity: | high | Docs Contact: | Clayton Spicer <cspicer> |
| Priority: | high | ||
| Version: | 7.2 | CC: | clumens, cww, haldir.junk, mbanas, mkovarik, salmy |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | pykickstart-1.99.66.7-1 | Doc Type: | Bug Fix |
| Doc Text: |
Kickstart files valid for Red Hat Enterprise Linux 6 are now correctly recognized by "ksvalidator"
Previously, when using the "ksvalidator" utility to validate a Kickstart file made for Red Hat Enterprise Linux 6 that uses the "logvol" command with the `--reserved-percent` option, "ksvalidator" incorrectly stated that `--reserved-percent` is not a valid option. This bug has been fixed.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-04 00:11:11 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1203710, 1295926, 1313485 | ||
|
Description
jcastran
2015-12-09 22:32:36 UTC
Just a bit more info: This does work properly in 1.74 (the version in RHEL6). The validation function for volgroup differs between these versions: From volgroup.py v.1.74: class RHEL6_VolGroup(F16_VolGroup): And from v.1.99: class RHEL6_VolGroup(FC3_VolGroup): FC16_VolGroup inherits from FC3_VolGroup and adds "--reserved-percent" as a valid option. Using FC16_VolGroup in 1.99 allows it to work as expected (as well as adjusting the parse line later in the function). Needs a cherry-pick of 207ca9a5f371415096a2a3f3d9d88798a7ecd9ef. FYI: One of my coworkers submitted a patch for this issue which was merged in the upstream project: https://github.com/rhinstaller/pykickstart/pull/53 Ah I see that is the commit that was referred to. Awesome, sorry for the noise. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-2184.html |