RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1290324 - libvirt should forbid set current cpu is 0 in xml
Summary: libvirt should forbid set current cpu is 0 in xml
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.2
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Peter Krempa
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-12-10 08:55 UTC by Luyao Huang
Modified: 2016-11-03 18:49 UTC (History)
4 users (show)

Fixed In Version: libvirt-1.3.2-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-03 18:49:33 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:2577 0 normal SHIPPED_LIVE Moderate: libvirt security, bug fix, and enhancement update 2016-11-03 12:07:06 UTC

Description Luyao Huang 2015-12-10 08:55:19 UTC 
Description of problem:

libvirt should forbid set current cpu to 0

Version-Release number of selected component (if applicable):

libvirt-1.2.17-13.el7_2.2.x86_64
How reproducible:
100%

Steps to Reproduce:
1. prepare a inactive guest:

# virsh list --all
 Id    Name                           State
----------------------------------------------------
 -     RHEL71-lhuang-novhost          shut off

2. edit guest xml and make current cpu to 0:

  <vcpu placement='static' current='0'>16</vcpu>

# virsh edit RHEL71-lhuang-novhost
error: XML document failed to validate against schema: Unable to validate doc against /usr/share/libvirt/schemas/domain.rng
Extra element vcpu in interleave
Invalid sequence in interleave
Element domain failed to validate content

Failed. Try again? [y,n,i,f,?]:
Domain RHEL71-lhuang-novhost XML configuration edited.

3. check xml:

# virsh dumpxml RHEL71-lhuang-novhost | grep current
  <currentMemory unit='KiB'>1153433</currentMemory>
  <vcpu placement='static' current='0'>16</vcpu>

4. try to start this guest:

# virsh start RHEL71-lhuang-novhost
error: Failed to start domain RHEL71-lhuang-novhost
error: internal error: got wrong number of vCPU pids from QEMU monitor. got 16, wanted 0

5. try some command:

# virsh vcpupin RHEL71-lhuang-novhost
error: ncpumaps in virDomainGetVcpuPinInfo must be greater than zero
 
# virsh vcpuinfo RHEL71-lhuang-novhost
error: ncpumaps in virDomainGetVcpuPinInfo must be greater than zero

Actual results:

libvirt allow set current vcpu to 0, but it doesn't make sense 

Expected results:

forbid it

Additional info:
Comment 1 Peter Krempa 2016-01-25 16:55:52 UTC 
commit b3c91b8a50ac0d772f883e737252202d48658139
Author: Peter Krempa <pkrempa>
Date:   Wed Jan 6 16:27:45 2016 +0100

    qemu: process: Disallow VMs with 0 vcpus
    
    Counterintuitively the user would end up with a VM with maximum number
    of vCPUs available.
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1290324

v1.3.1-44-gb3c91b8
Comment 3 Luyao Huang 2016-08-09 01:54:46 UTC 
Verify this bug with libvirt-2.0.0-4.el7.x86_64:

1. edit guest with current vcpu = 0:

# virsh dumpxml r7 |grep current=
  <vcpu placement='static' current='0'>10</vcpu>

2. try to start guest and libvirt report an error:

# virsh start r7
error: Failed to start domain r7
error: unsupported configuration: Domain requires at least 1 vCPU

3. try other command:

# virsh vcpucount r7
maximum      config        10

# virsh vcpuinfo r7
error: ncpumaps in virDomainGetVcpuPinInfo must be greater than zero

# virsh vcpupin r7
VCPU: CPU Affinity
----------------------------------
   0: 0-23
   1: 0-23
   2: 0-23
   3: 0-23
   4: 0-23
   5: 0-23
   6: 0-23
   7: 0-23
   8: 0-23
   9: 0-23
Comment 5 errata-xmlrpc 2016-11-03 18:49:33 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2577.html
Note You need to log in before you can comment on or make changes to this bug.