Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1290427

Summary:	snapshot without disks gets deleted automatically once a snapshot gets commited
Product:	[oVirt] ovirt-engine	Reporter:	Maor <mlipchuk>
Component:	BLL.Storage	Assignee:	Maor <mlipchuk>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Kevin Alon Goldblatt <kgoldbla>
Severity:	high	Docs Contact:
Priority:	high
Version:	3.5.0	CC:	acanan, amureini, bugs, derez, stirabos, tnisan
Target Milestone:	ovirt-4.0.0-rc	Flags:	rule-engine: ovirt-4.0.0+ rule-engine: planning_ack+ amureini: devel_ack+ acanan: testing_ack+
Target Release:	4.0.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-01 12:27:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Maor 2015-12-10 13:33:51 UTC

Description of problem:
previewing a snapshot without any disks and committing it will cause the earlier snapshots to get deleted, although they might contain VM configuration data.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a VM with image disk
2. Create a snapshot containing this disk
3. Create another snapshot without this disk
4. Try to preview the last snapshot (The one without the disk)
5. commit the snapshot

Actual results:
The first snapshot gets deleted

Expected results:
The first snapshot should not get deleted since it is also containing the VM's configuration

Additional info:

Comment 1 Maor 2015-12-23 09:47:25 UTC

The origin of this bug is that the hierarchy of snapshots is defined by the images and not the snapshots table.
The fix for that should be to define parent and child also for snapshots and maybe neglect the use of images hierarchy to be used for commit and preview.
Since this behavior reflects a big change that needs to be tested with all the relevant scenarios, and this bug is a small use case of snapshots without disks.
I'm changing the target to 4.0

Comment 2 Red Hat Bugzilla Rules Engine 2015-12-23 09:47:29 UTC

This bug is marked for z-stream, yet the milestone is for a major version, therefore the milestone has been reset.
Please set the correct milestone or drop the z stream flag.

Comment 3 Sandro Bonazzola 2016-05-02 10:02:43 UTC

Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.

Comment 4 Yaniv Lavi 2016-05-23 13:17:58 UTC

oVirt 4.0 beta has been released, moving to RC milestone.

Comment 5 Yaniv Lavi 2016-05-23 13:21:57 UTC

oVirt 4.0 beta has been released, moving to RC milestone.

Comment 6 Kevin Alon Goldblatt 2016-07-14 08:30:01 UTC

Verified with the following code:
---------------------------------------
vdsm-4.18.4-2.el7ev.x86_64
rhevm-4.0.2-0.2.rc1.el7ev.noarch

Verified using the following scenario:
---------------------------------------
1. Create a VM with image disk
2. Create a snapshot containing this disk
3. Create another snapshot without this disk
4. Try to preview the last snapshot (The one without the disk)
5. commit the snapshot

Actual results:
The first snapshot remains in tact


Moving to VERIFIED!