Description of problem: previewing a snapshot without any disks and committing it will cause the earlier snapshots to get deleted, although they might contain VM configuration data. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Create a VM with image disk 2. Create a snapshot containing this disk 3. Create another snapshot without this disk 4. Try to preview the last snapshot (The one without the disk) 5. commit the snapshot Actual results: The first snapshot gets deleted Expected results: The first snapshot should not get deleted since it is also containing the VM's configuration Additional info:
The origin of this bug is that the hierarchy of snapshots is defined by the images and not the snapshots table. The fix for that should be to define parent and child also for snapshots and maybe neglect the use of images hierarchy to be used for commit and preview. Since this behavior reflects a big change that needs to be tested with all the relevant scenarios, and this bug is a small use case of snapshots without disks. I'm changing the target to 4.0
This bug is marked for z-stream, yet the milestone is for a major version, therefore the milestone has been reset. Please set the correct milestone or drop the z stream flag.
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.
oVirt 4.0 beta has been released, moving to RC milestone.
Verified with the following code: --------------------------------------- vdsm-4.18.4-2.el7ev.x86_64 rhevm-4.0.2-0.2.rc1.el7ev.noarch Verified using the following scenario: --------------------------------------- 1. Create a VM with image disk 2. Create a snapshot containing this disk 3. Create another snapshot without this disk 4. Try to preview the last snapshot (The one without the disk) 5. commit the snapshot Actual results: The first snapshot remains in tact Moving to VERIFIED!