Bug 1290728 - [devexp_public_640] Can add duplicate build steps in jenkins configure page
[devexp_public_640] Can add duplicate build steps in jenkins configure page
Status: CLOSED NOTABUG
Product: OpenShift Container Platform
Classification: Red Hat
Component: Image (Show other bugs)
3.1.0
Unspecified Unspecified
low Severity low
: ---
: ---
Assigned To: Gabe Montero
wewang
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2015-12-11 04:12 EST by wewang
Modified: 2015-12-11 11:51 EST (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2015-12-11 09:51:25 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description wewang 2015-12-11 04:12:37 EST
Version-Release number of selected component (if applicable):
openshift/jenkins-1-rhel7  27fca1f9ef45

How reproducible:
always

Description of problem:
Can add several same build steps via "add build steps" in jenkins configure page, I think should control it

Steps to Reproduce:
1. logged in to openshift as a normal user and working with a project named wewang

2. Add the edit role to the default service account in the wewang project:
   $ oc policy add-role-to-user edit system:serviceaccount:wewang:default
   
3. create is in project wewang and deploy the Jenkins service
   $ oc new-app jenkins-ephemeral-template.json
   $oc get route
    NAME      HOST/PORT                                         PATH      SERVICE   LABELS                                INSECURE POLICY   TLS TERMINATION
    jenkins   jenkins-wewang.router.default.svc.cluster.local             jenkins   template=jenkins-ephemeral-template                     edge

4. Visit jenkins webpage and select job "OpenShift Sample" to Configure
   pull down "add build step", select "Check Deployment Success in openshift", will add the build step, do it again, can add it again


  Actual results:
   Can add duplicate  build steps  
  
 Expected results:
   Cannot add the same build steps
Comment 1 Gabe Montero 2015-12-11 09:51:25 EST
Unfortunately there is no way for the plugin to prevent you from adding duplicate steps.  Jenkins does not provide that sort of hook point.
Comment 2 Ben Parees 2015-12-11 10:07:47 EST
i'm not sure we want to prevent this anyway.  I could want to check deployment success for multiple deployments.
Comment 3 Gabe Montero 2015-12-11 11:51:29 EST
Agreed - in fact the sample job in the image does that.

Note You need to log in before you can comment on or make changes to this bug.