Bug 1291687 - Backport: L3 agent: explicit call to resync on init may lead to double syncing
Summary: Backport: L3 agent: explicit call to resync on init may lead to double syncing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-neutron
Version: 6.0 (Juno)
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: async
: 6.0 (Juno)
Assignee: Nir Magnezi
QA Contact: Toni Freger
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-12-15 12:38 UTC by Nir Magnezi
Modified: 2023-02-22 23:02 UTC (History)
8 users (show)

Fixed In Version: openstack-neutron-2014.2.3-30.el7ost
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-08 14:18:21 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1505282 0 None None None Never
Red Hat Product Errata RHBA-2016:0130 0 normal SHIPPED_LIVE openstack-neutron bug fix and enhancement advisory 2016-02-08 19:16:42 UTC

Description Nir Magnezi 2015-12-15 12:38:28 UTC
Description of problem:
=======================
Currently L3 agent has an explicit call to self.periodic_sync_routers_task() after initialization.
Given that periodic job spacing is set to 1 second, this may lead to double syncing with server on initialization (especially if there are a lot of routers scheduled to the agent):
 - agent starts, fullsync flag is True
 - periodic_sync_routers_task is called from after_start(), agent requests router info from server, fullsync flag is True
 - periodic_sync_routers_task is called by periodic task framework, fullsync flag is still True, agent requests router info from server once again.
So it's double work on both server and agent sides which might be quite expensive at scale.

The proposal is to just use run_immediately parameter.


To fix this, we should backport https://bugs.launchpad.net/neutron/+bug/1505282

Comment 4 Toni Freger 2016-01-19 15:14:50 UTC
The code exists within the release.
Tested on openstack-neutron-2014.2.3-32.el7ost.noarch

Comment 6 errata-xmlrpc 2016-02-08 14:18:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0130.html


Note You need to log in before you can comment on or make changes to this bug.