Bug 1291726

Requesting feedback from Dan Sneddon, as he's the OSPd networking expert.

I just tested it with active-backup as the bonding mode and it works fine. 

My understanding is that if the switches support something like the Arista LACP fallback this should work fine.

This is the template I tested with for the controller NICs:

resources:
  OsNetConfigImpl:
    type: OS::Heat::StructuredConfig
    properties:
      group: os-apply-config
      config:
        os_net_config:
          network_config:
            -
              type: ovs_bridge
              name: br-provisioning
              use_dhcp: false
              dns_servers: {get_param: DnsServers}
              addresses:
                -
                  ip_netmask:
                    list_join:
                      - '/'
                      - - {get_param: ControlPlaneIp}
                        - {get_param: ControlPlaneSubnetCidr}
              routes:
                -
                  ip_netmask: 169.254.169.254/32
                  next_hop: {get_param: EC2MetadataIp}
              members:
                -
                  type: ovs_bond
                  name: bond-prov
                  ovs_options: bond_mode=active-backup
                  members:
                    -
                      type: interface
                      name: nic1
                      primary: true
                    -
                      type: interface
                      name: nic2
                -
                  type: vlan
                  vlan_id: {get_param: ExternalNetworkVlanID}
                  addresses:
                  -
                    ip_netmask: {get_param: ExternalIpSubnet}
                  routes:
                    -
                      defroute: true
                      next_hop: {get_param: ExternalInterfaceDefaultRoute}
                -
                  type: vlan
                  vlan_id: {get_param: InternalApiNetworkVlanID}
                  addresses:
                  -
                    ip_netmask: {get_param: InternalApiIpSubnet}
                -
                  type: vlan
                  vlan_id: {get_param: StorageNetworkVlanID}
                  addresses:
                  -
                    ip_netmask: {get_param: StorageIpSubnet}
                -
                  type: vlan
                  vlan_id: {get_param: TenantNetworkVlanID}
                  addresses:
                  -
                    ip_netmask: {get_param: TenantIpSubnet}
            -
              type: interface
              name: nic3
              use_dhcp: false
              defroute: false

As you can see all the services are in the same bond which uses has nic1 as one of its two bond slaves. This test worked out of the box.

(In reply to Ramon Acedo from comment #7)
> I just tested it with active-backup as the bonding mode and it works fine. 
> 
> My understanding is that if the switches support something like the Arista
> LACP fallback this should work fine.

Ramon is correct. Active/backup links are confirmed to be working. LACP links with LACP fallback should also work fine, and we have reports that they do, but we haven't done that testing in house yet. Note that LACP fallback is only supported on a limited number of switch makes/models, and the configuration can be a little tricky. Testing should be done on site to ensure that the configuration is allowing for introspection and deployment PXE boot.

Dan, based on the information you wrote above, is there something else left to be implemented or can we move it to QA only? Thanks

(In reply to Jaromir Coufal from comment #9)
> Dan, based on the information you wrote above, is there something else left
> to be implemented or can we move it to QA only? Thanks

This works. It is fully implemented. We have customers using this configuration in production. If you want to send it to QE, go ahead. It will pass, and if they are having trouble then I can help them.

Part of the problem may be that this bug applies when using this configuration (and the associated workarounds are required):

https://bugzilla.redhat.com/show_bug.cgi?id=1234601