Bug 1292751 - (RHEL7) hook script for CTDB should not change Samba config
Summary: (RHEL7) hook script for CTDB should not change Samba config
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: samba
Version: rhgs-3.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: RHGS 3.1.2
Assignee: Michael Adam
QA Contact: surabhi
URL:
Whiteboard:
Depends On: 1290151 1292254 1292605
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-12-18 09:38 UTC by Michael Adam
Modified: 2016-03-01 06:14 UTC (History)
8 users (show)

Fixed In Version: glusterfs-3.7.5-13
Doc Type: Bug Fix
Doc Text:
Cause: S29CTDB hook scripts modify Samba's global configuration and restart Samba when the ctdb lock volume is started or stopped. Specifically 'clustering = yes' and 'idmap backend = tdb2' are added and removed. Consequence: This can have undesired effects. Manual changes to the smb.conf file may get overwritten. It is not reliably possible to use a custom idmap configuration. More seriously, a samba installation is either clustered or not cluster. If this changes, data access may be lost, and data corruption can happen. Fix: Stop the S29CTDB hook scripts from changing Samba configuration and restarting Samba. Result: Manual changes to the global section of smb.conf are safe, and data corruption is prevented.
Clone Of: 1292605
Environment:
Last Closed: 2016-03-01 06:14:06 UTC
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:0192 0 normal SHIPPED_LIVE Red Hat Gluster Storage 3.1 update 2 2016-03-01 10:32:25 UTC

Comment 3 rjoseph 2015-12-19 05:36:15 UTC 
Upstream master: http://review.gluster.org/12930
Upstream release-3.7: http://review.gluster.org/12986
Downstream: https://code.engineering.redhat.com/gerrit/#/c/64210/
Comment 5 surabhi 2015-12-29 11:13:30 UTC 
Please add the fixed in Version
Comment 6 surabhi 2015-12-29 12:01:20 UTC 
Verified the BZ on RHEL7 with following build :
glusterfs-3.7.5-13.el7rhgs.x86_64
samba-4.2.4-12.el7rhgs.x86_64

Following steps are executed:

1.Create a ctdb lock volume as per admin guide instructions
2.Update the S29CTDBSetup and S29teardown hook scripts to add the ctdb volume name in meta=all.
3.started the ctdb volume
4.Verified the mount point /gluster/lock
5.Verified the entries in smb.conf , there should not be any entry created by ctdb volume start(via hook script): the clustering=yes, idmap-backend entry is not added to smb.conf via hook script.
6. Also verified after adding the clustering=yes in smb.conf and stopping ctdb volume does not remove the entry from smb.conf.
7.Started ctdb services , ctdb starts successfully and starts smb service.
8. Again stopped and started the ctdb volume , the smbd service is not restarted.

Marking the BZ verified.
Comment 8 errata-xmlrpc 2016-03-01 06:14:06 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0192.html
Note You need to log in before you can comment on or make changes to this bug.