RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1292926 - firewalld --new-service & malformed xml ??
Summary: firewalld --new-service & malformed xml ??
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: firewalld
Version: 7.1
Hardware: x86_64
OS: Linux
medium
low
Target Milestone: rc
: ---
Assignee: Thomas Woerner
QA Contact: Jan Kepler
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-12-18 18:49 UTC by lejeczek
Modified: 2016-11-03 21:02 UTC (History)
2 users (show)

Fixed In Version: firewalld-0.4.2-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-03 21:02:04 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:2597 0 normal SHIPPED_LIVE Moderate: firewalld security, bug fix, and enhancement update 2016-11-03 12:11:47 UTC

Description lejeczek 2015-12-18 18:49:55 UTC 
Description of problem:

I prepare an xml:

<service>
  <short>Xelerance l2tpd</short>
  <description>A Layer 2 Tunneling Protocol VPN client/daemon for Linux and other POSIX-based OSs. Based off of L2TPd 0.61.</description>
  <port protocol="udp" port="1701"/>
</service>

I execute:
$ firewall-cmd --permanent --new-service=xl2tpd
I see file got copied into /etc/firewalld/services/ but
$ firewall-cmd --get-services
show no such service, so I do: systemctl restart firewalld - now --get-services list it but I end up with:

<?xml version="1.0" encoding="utf-8"?>
<service>
</service>

effectively having no results on iptables after adding the service to a zone


Version-Release number of selected component (if applicable):

firewalld-0.3.9-11.el7.noarch

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 2 Thomas Woerner 2016-01-18 11:55:55 UTC 
--new-service creates a new service, but is not using a local file for this. This would be very good to add, though.
Comment 3 Thomas Woerner 2016-01-18 11:57:29 UTC 
I think about --new-service-from-file=<file> or --new-service=<name> --file=<file>
Comment 4 lejeczek 2016-01-18 13:50:43 UTC 
I see.. Yes, it would be very useful indeed to be able to use prepped file.
Comment 5 lejeczek 2016-01-18 16:39:36 UTC 
also, if I may, --service-info which could dump whole lot about service would be nice too.
Comment 6 lejeczek 2016-01-27 17:33:29 UTC 
and would it great not to have to reload the daemon to see this newly added service.
Comment 7 lejeczek 2016-01-27 18:03:06 UTC 
I've just come across something, I've tried man pages but could not find any info on '&' char. 
And it seems that if it is in .xml file (I had in <description>) then firewalld omits silently.
Comment 8 Thomas Woerner 2016-01-28 12:59:18 UTC 
The ampersand is a special character in XML: https://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references

If you are writing into an XML file, you need to take care about the syntax.
Comment 9 lejeczek 2016-01-28 13:34:50 UTC 
yes, but this - if one makes one mistake in one .xml then the rest, if there are other custom services xmls, get silently skipped! Services are there listed as attached to zones but ports are not opened!

test it - make a mistake in <port> eg. put 443,444 instead of 443-444 (and I imagine many of us will be makeing it, old iptables style habit) and all custom services are affected.
I'd be nice to have firewalld resilient to this.
Comment 11 Thomas Woerner 2016-01-28 18:21:32 UTC 
(In reply to lejeczek from comment #9)
> yes, but this - if one makes one mistake in one .xml then the rest, if there
> are other custom services xmls, get silently skipped! Services are there
> listed as attached to zones but ports are not opened!
> 

Please open an extra bug for this - it is a different issue.
Comment 13 Thomas Woerner 2016-05-25 15:43:57 UTC 
Fixed upstream:

https://github.com/t-woerner/firewalld/commit/35802812f374f8075c07cae672e150069ea6117a
https://github.com/t-woerner/firewalld/commit/6df8dfa079817ef4c60388b45679426ed5bea2cd
Comment 17 errata-xmlrpc 2016-11-03 21:02:04 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2597.html
Note You need to log in before you can comment on or make changes to this bug.