Bug 1293567 - rpmlint generates error messages for rhscon-core package
Summary: rpmlint generates error messages for rhscon-core package
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Storage Console
Classification: Red Hat Storage
Component: build
Version: 2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 2
Assignee: Shubhendu Tripathi
QA Contact: sds-qe-bugs
URL:
Whiteboard:
Depends On:
Blocks: Console-2-GA
TreeView+ depends on / blocked
 
Reported: 2015-12-22 08:19 UTC by Martin Kudlej
Modified: 2016-08-23 19:47 UTC (History)
7 users (show)

Fixed In Version: rhscon-core-0.0.35-1.el7scon.x86_64
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-23 19:47:44 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gerrithub.io 284040 0 None None None 2016-07-19 04:08:23 UTC
Red Hat Product Errata RHEA-2016:1754 0 normal SHIPPED_LIVE New packages: Red Hat Storage Console 2.0 2017-04-18 19:09:06 UTC

Description Martin Kudlej 2015-12-22 08:19:03 UTC
Description of problem:
There are errors and warning in rpmlint check of rhscon-core package.

Version-Release number of selected component (if applicable):
rhscon-core-0.0.1-1.el7.x86_64.rpm

How reproducible:
100%

Steps to Reproduce:
1. rpmlint -i rhscon-core-0.0.1-1.el7.x86_64.rpm

Actual results:
6 errors, 10 warnings.

Expected results:
No errors. No warnings if it is possible.

Additional info:
$ rpmlint -i rhscon-core-0.0.1-1.el7.x86_64.rpm
rhscon-core.x86_64: W: non-standard-group Applications/Storage
The value of the Group tag in the package is not valid.  Valid groups are:
"Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
"Applications/Communications", "Applications/Databases",
"Applications/Editors", "Applications/Emulators", "Applications/Engineering",
"Applications/File", "Applications/Internet", "Applications/Multimedia",
"Applications/Productivity", "Applications/Publishing", "Applications/System",
"Applications/Text", "Development/Debug", "Development/Debuggers",
"Development/Languages", "Development/Libraries", "Development/System",
"Development/Tools", "Documentation", "System Environment/Base", "System
Environment/Daemons", "System Environment/Kernel", "System
Environment/Libraries", "System Environment/Shells", "Unspecified", "User
Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

rhscon-core.x86_64: W: no-version-in-last-changelog
The latest changelog entry doesn't contain a version. Please insert the
version that is coherent with the version of the package and rebuild it.

rhscon-core.x86_64: W: invalid-license Apache-2.0
The value of the License tag was not recognized.  Known values are: "AAL",
"Abstyles", "Adobe", "ADSL", "AFL", "Afmparse", "AGPLv1", "AGPLv3", "AGPLv3
with exceptions", "AMDPLPA", "AML", "AMPAS BSD", "APAFML", "APSL 2.0", "APSL
2.0+", "ARL", "Artistic 2.0", "Artistic clarified", "ASL 1.0", "ASL 1.0+",
"ASL 1.1", "ASL 1.1+", "ASL 2.0", "ASL 2.0+", "Bahyph", "Barr", "Beerware",
"BeOpen", "Bibtex", "BitTorrent", "Boost", "Borceux", "BSD", "BSD Protection",
"BSD with advertising", "BSD with attribution", "CATOSL", "CC0", "CeCILL",
"CeCILL-B", "CeCILL-C", "CDDL", "CNRI", "Condor", "Copyright only", "CPAL",
"CPL", "Crossword", "Crystal Stacker", "Cube", "diffmark", "DOC", "Dotseqn",
"DSDP", "dvipdfm", "ECL 1.0", "ECL 2.0", "eCos", "EFL 2.0", "EFL 2.0+",
"eGenix", "Entessa", "EPL", "ERPL", "EU Datagrid", "EUPL 1.1", "Eurosym",
"Fair", "FSFUL", "FSFULLR", "FTL", "Giftware", "GL2PS", "Glide", "Glulxe",
"gnuplot", "GPL+", "GPL+ or Artistic", "GPL+ with exceptions", "GPLv1", "GPLv2
or Artistic", "GPLv2+ or Artistic", "GPLv2", "GPLv2 with exceptions",
"GPLv2+", "GPLv2+ with exceptions", "GPLv3", "GPLv3 with exceptions",
"GPLv3+", "GPLv3+ with exceptions", "HaskellReport", "IBM", "IJG",
"ImageMagick", "iMatix", "Imlib2", "Intel ACPI", "Interbase", "ISC", "Jabber",
"JasPer", "JPython", "Julius", "Knuth", "Latex2e", "LBNL BSD", "Leptonica",
"LGPLv2", "LGPLv2 with exceptions", "LGPLv2+", "LGPLv2+ or Artistic", "LGPLv2+
with exceptions", "LGPLv3", "LGPLv3 with exceptions", "LGPLv3+", "LGPLv3+ with
exceptions", "Lhcyr", "libtiff", "LLGPL", "Logica", "LPL", "LPPL",
"MakeIndex", "mecab-ipadic", "midnight", "MirOS", "MIT", "MITNFA", "MIT with
advertising", "mod_macro", "Motosoto", "MPLv1.0", "MPLv1.0+", "MPLv1.1",
"MPLv1.1+", "MPLv2.0", "MS-PL", "MS-RL", "MTLL", "Mup", "Naumen", "NCSA",
"NetCDF", "Netscape", "Newmat", "Newsletr", "NGPL", "NLPL", "Nokia", "NOSL",
"Noweb", "OML", "OpenLDAP", "OpenPBS", "OpenSSL", "OReilly", "OSL 1.0", "OSL
1.0+", "OSL 1.1", "OSL 1.1+", "OSL 2.0", "OSL 2.0+", "OSL 2.1", "OSL 2.1+",
"OSL 3.0", "OSL 3.0+", "Par", "Phorum", "PHP", "PlainTeX", "Plexus",
"PostgreSQL", "psfrag", "psutils", "Public Domain", "Python", "Qhull", "QPL",
"Rdisc", "RiceBSD", "Romio", "RPSL", "Rsfs", "Ruby", "Saxpath", "SCEA",
"SCRIP", "Sendmail", "Sleepycat", "SISSL", "SLIB", "SNIA", "softSurfer",
"SPL", "STMPL", "SWL", "TCL", "Teeworlds", "Threeparttable", "TMate",
"TORQUEv1.1", "TOSL", "TPL", "UCD", "Vim", "VNLSL", "VOSTROM", "VSL", "W3C",
"Webmin", "Wsuipa", "WTFPL", "wxWidgets", "Xerox", "xinetd", "xpp", "XSkat",
"YPLv1.1", "Zed", "Zend", "zlib", "zlib with acknowledgement", "ZPLv1.0",
"ZPLv1.0+", "ZPLv2.0", "ZPLv2.0+", "ZPLv2.1", "ZPLv2.1+", "CDL", "FBSDDL",
"GFDL", "IEEE", "LDPL", "OFSFDL", "Open Publication", "Public Use",
"Verbatim", "CC-BY", "CC-BY-ND", "CC-BY-SA", "DMTF", "DSL", "EFML", "Free
Art", "GeoGratis", "Green OpenMusic", "OAL", "AMS", "Arphic", "Baekmuk",
"Bitstream Vera", "DoubleStroke", "Hershey", "IPA", "Liberation", "Lucida",
"MgOpen", "mplus", "OFL", "PTFL", "STIX", "Utopia", "Wadalab", "XANO",
"Redistributable, no modification permitted", "Freely redistributable without
restriction".

rhscon-core.x86_64: W: invalid-url URL github.com/skyrings/skyring
The value should be a valid, public HTTP, HTTPS, or FTP URL.

rhscon-core.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

rhscon-core.x86_64: E: script-without-shebang /usr/lib/python2.7/site-packages/skyring/__init__.py
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.

rhscon-core.x86_64: E: wrong-script-interpreter /srv/salt/push_event.sls py
This script uses an incorrect interpreter.

rhscon-core.x86_64: E: script-without-shebang /etc/salt/master.d/skyring.conf
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.

rhscon-core.x86_64: E: script-without-shebang /etc/skyring/skyring.conf
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.

rhscon-core.x86_64: E: script-without-shebang /usr/lib/python2.7/site-packages/skyring/saltwrapper.py
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.

rhscon-core.x86_64: E: script-without-shebang /etc/skyring/authentication.conf
This text file has executable bits set or is located in a path dedicated for
executables, but lacks a shebang and cannot thus be executed.  If the file is
meant to be an executable script, add the shebang, otherwise remove the
executable bits or move the file elsewhere.

rhscon-core.x86_64: W: log-files-without-logrotate /var/log/skyring
This package contains files in /var/log/ without adding logrotate
configuration for them.

rhscon-core.x86_64: W: no-manual-page-for-binary skyring-setup.sh
Each executable in standard binary directories should have a man page.

rhscon-core.x86_64: W: no-manual-page-for-binary skyring
Each executable in standard binary directories should have a man page.

rhscon-core.x86_64: W: empty-%post
rhscon-core.x86_64: W: empty-%preun
1 packages and 0 specfiles checked; 6 errors, 10 warnings.

Comment 2 Timothy Asir 2016-03-30 12:09:57 UTC
Patch sent to upstream for review
https://review.gerrithub.io/#/c/270821/

Comment 3 Martin Kudlej 2016-05-17 11:36:57 UTC
There is still error in rpmlint:
$ rpmlint -i rhscon-core-0.0.18-1.el7scon.x86_64.rpm 
rhscon-core.x86_64: W: incoherent-version-in-changelog 0.0.18-1 ['0.0.18-1.el7scon', '0.0.18-1.el7scon']
The latest entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

rhscon-core.x86_64: E: wrong-script-interpreter /srv/salt/push_event.sls py
This script uses an incorrect interpreter.

rhscon-core.x86_64: W: log-files-without-logrotate ['/var/log/skyring']
This package contains files in /var/log/ without adding logrotate
configuration for them.

rhscon-core.x86_64: W: dangerous-command-in-%post ln
rhscon-core.x86_64: W: dangerous-command-in-%postun mv
rhscon-core.x86_64: W: dangerous-command-in-%trigger mv
rhscon-core.x86_64: W: dangerous-command-in-%trigger mv
rhscon-core.x86_64: W: dangerous-command-in-%trigger rm
1 packages and 0 specfiles checked; 1 errors, 7 warnings.
-->Assigned

Comment 4 Martin Kudlej 2016-07-14 07:56:02 UTC
There are still errors in rpmlint:
rpmlint -i rhscon-core
rhscon-core.x86_64: W: incoherent-version-in-changelog 0.0.33-1 ['0.0.33-1.el7scon', '0.0.33-1.el7scon']
The latest entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

rhscon-core.x86_64: E: wrong-script-interpreter /srv/salt/push_event.sls py
This script uses an incorrect interpreter.

rhscon-core.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/skyring
Your logrotate file should be named /etc/logrotate.d/<package name>.

rhscon-core.x86_64: W: no-manual-page-for-binary skyring-setup
Each executable in standard binary directories should have a man page.

rhscon-core.x86_64: W: no-manual-page-for-binary skyring-pre.sh
Each executable in standard binary directories should have a man page.

rhscon-core.x86_64: W: dangerous-command-in-%postun mv
rhscon-core.x86_64: W: dangerous-command-in-%trigger mv
rhscon-core.x86_64: W: dangerous-command-in-%trigger mv
rhscon-core.x86_64: W: dangerous-command-in-%trigger rm
1 packages and 0 specfiles checked; 2 errors, 7 warnings.

Comment 5 Timothy Asir 2016-07-14 11:00:23 UTC
This bug was fixed long back almost 10 build back. Now this has come after we introduce log-rotate. Please close this bug and raise a fresh bug. Reopen bug is confusing.

Comment 7 Martin Kudlej 2016-07-14 11:23:11 UTC
I think this bug cannot be in ON_QA if there are still issues. --> Assigned

Comment 8 Shubhendu Tripathi 2016-07-19 04:08:24 UTC
The error

"rhscon-core.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/skyring
Your logrotate file should be named /etc/logrotate.d/<package name>."

is fixed as part of patch https://review.gerrithub.io/#/c/284040/.

And the error

"rhscon-core.x86_64: E: wrong-script-interpreter /srv/salt/push_event.sls py
This script uses an incorrect interpreter."

should be waived off as the script needs the interpreter the way its mentioned and cannot be changed.

Comment 9 Martin Kudlej 2016-07-27 12:41:28 UTC
rpmlint rhscon-core
rhscon-core.x86_64: W: incoherent-version-in-changelog 0.0.36-1 ['0.0.36-1.el7scon', '0.0.36-1.el7scon']
rhscon-core.x86_64: E: wrong-script-interpreter /srv/salt/push_event.sls py
rhscon-core.x86_64: W: no-manual-page-for-binary skyring-setup
rhscon-core.x86_64: W: no-manual-page-for-binary skyring-pre.sh
rhscon-core.x86_64: W: dangerous-command-in-%postun mv
rhscon-core.x86_64: W: dangerous-command-in-%trigger mv
rhscon-core.x86_64: W: dangerous-command-in-%trigger mv
rhscon-core.x86_64: W: dangerous-command-in-%trigger rm
1 packages and 0 specfiles checked; 1 errors, 7 warnings.

Comment 11 errata-xmlrpc 2016-08-23 19:47:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2016:1754


Note You need to log in before you can comment on or make changes to this bug.