1294813 – [geo-rep]: Multiple geo-rep session to the same slave is allowed for different users

Bug 1294813 - [geo-rep]: Multiple geo-rep session to the same slave is allowed for different users

Summary: [geo-rep]: Multiple geo-rep session to the same slave is allowed for differen...

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	GlusterFS
Classification:	Community
Component:	geo-replication
Sub Component:
Version:	mainline
Hardware:	x86_64
OS:	Linux
Priority:	high
Severity:	high
Target Milestone:	---
Assignee:	Saravanakumar
QA Contact:
Docs Contact:
URL:
Whiteboard:
Depends On:	1261838
Blocks:	1335728 1336704
TreeView+	depends on / blocked

Reported:	2015-12-30 12:44 UTC by Saravanakumar
Modified:	2017-03-10 06:30 UTC (History)
CC List:	9 users (show)
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Clone Of:	1261838
Clones:	1335728 1336704 (view as bug list)
Environment:
Last Closed:	2017-03-10 06:30:00 UTC
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Embargoed:
Dependent Products:

Attachments	(Terms of Use)

Comment 1 Vijay Bellur 2015-12-30 12:45:06 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave vol uuid to geo-rep session [WIP]) posted (#4) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 2 Vijay Bellur 2016-01-05 15:37:40 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave vol uuid to geo-rep session) posted (#6) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 3 Vijay Bellur 2016-01-06 12:49:07 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave vol uuid to geo-rep session) posted (#7) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 4 Vijay Bellur 2016-02-18 11:12:05 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave vol uuid to geo-rep session) posted (#8) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 5 Vijay Bellur 2016-02-22 13:49:26 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave vol uuid to geo-rep session) posted (#9) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 6 Vijay Bellur 2016-02-24 15:34:39 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave vol uuid to geo-rep session) posted (#10) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 7 Vijay Bellur 2016-03-03 14:00:18 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave vol uuid to geo-rep session) posted (#11) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 8 Vijay Bellur 2016-03-07 08:39:13 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave vol uuid in geo-rep session) posted (#12) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 9 Vijay Bellur 2016-03-14 08:43:45 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave vol uuid in geo-rep session) posted (#13) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 10 Vijay Bellur 2016-03-17 09:57:35 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave vol uuid in geo-rep session) posted (#14) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 11 Vijay Bellur 2016-03-22 11:15:38 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave volume uuid in geo-rep session) posted (#15) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 12 Mike McCune 2016-03-28 23:32:32 UTC

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 13 Vijay Bellur 2016-03-30 10:15:22 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave volume uuid in geo-rep session) posted (#16) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 14 Vijay Bellur 2016-04-12 09:59:18 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave volume uuid in geo-rep session) posted (#17) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 15 Vijay Bellur 2016-04-14 07:50:21 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave volume uuid in geo-rep session) posted (#18) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 16 Vijay Bellur 2016-04-14 11:20:20 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave volume uuid in geo-rep session) posted (#19) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 17 Vijay Bellur 2016-05-03 15:13:10 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave volume uuid in geo-rep session) posted (#20) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 18 Vijay Bellur 2016-05-03 15:14:05 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave volume uuid in geo-rep session) posted (#21) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 19 Vijay Bellur 2016-05-03 15:28:27 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave volume uuid in geo-rep session) posted (#22) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 20 Vijay Bellur 2016-05-03 15:37:09 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: involve slave volume uuid in geo-rep session) posted (#23) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 21 Vijay Bellur 2016-05-04 12:40:57 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#24) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 22 Vijay Bellur 2016-05-04 12:43:59 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#25) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 23 Vijay Bellur 2016-05-04 12:49:31 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#26) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 24 Vijay Bellur 2016-05-04 13:04:52 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#27) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 25 Vijay Bellur 2016-05-05 09:33:12 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#28) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 26 Vijay Bellur 2016-05-06 12:06:57 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#29) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 27 Vijay Bellur 2016-05-08 19:16:08 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#30) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 28 Vijay Bellur 2016-05-09 11:35:49 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#31) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 29 Vijay Bellur 2016-05-10 19:56:26 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#32) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 30 Vijay Bellur 2016-05-11 15:15:22 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#33) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 31 Vijay Bellur 2016-05-12 04:39:15 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#34) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 32 Vijay Bellur 2016-05-12 11:04:31 UTC

REVIEW: http://review.gluster.org/13111 (geo-rep: slave volume uuid to identify a geo-rep session) posted (#35) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 33 Vijay Bellur 2016-05-12 13:39:12 UTC

REVIEW: http://review.gluster.org/13111 (glusterd/geo-rep: slave volume uuid to identify a geo-rep session) posted (#36) for review on master by Aravinda VK (avishwan)

Comment 34 Vijay Bellur 2016-05-12 13:44:32 UTC

REVIEW: http://review.gluster.org/13111 (glusterd/geo-rep: slave volume uuid to identify a geo-rep session) posted (#37) for review on master by Aravinda VK (avishwan)

Comment 35 Vijay Bellur 2016-05-13 06:23:02 UTC

COMMIT: http://review.gluster.org/13111 committed in master by Aravinda VK (avishwan) 
------
commit a9128cda34b1f696b717ba09fa0ac5a929be8969
Author: Saravanakumar Arumugam <sarumuga>
Date:   Tue Dec 29 19:22:36 2015 +0530

    glusterd/geo-rep: slave volume uuid to identify a geo-rep session
    
    Problem:
    Currently, it is possible to create multiple geo-rep session from
    the Master host to Slave host(s), where Slave host(s) belonging
    to the same volume.
    
    For example:
    Consider Master Host M1 having volume tv1 and Slave volume tv2,
    which spans across two Slave hosts S1 and S2.
    Currently, it is possible to create geo-rep session from
    M1(tv1) to S1(tv2) as well as from M1(tv1) to S2(tv2).
    
    When the Slave Host is alone modified, it is identified as a new geo-rep
    session (as slave host and slave volume together are identifying
    Slave side).
    
    Also, it is possible to create both root and non-root geo-rep session between
    same Master volume and Slave volume. This should also be avoided.
    
    Solution:
    This multiple geo-rep session creation must be avoided and
    in order to avoid, use Slave volume uuid to identify a Slave.
    This way, we can identify whether a session is already created for
    the same Slave volume and avoid creating again (using different host).
    
    When the session creation is forced in the above scenario, rename
    the existing geo-rep session directory with new Slave Host mentioned.
    
    Change-Id: I9239759cbc0d15dad63c48b8cf62950bb687c7c8
    BUG: 1294813
    Signed-off-by: Saravanakumar Arumugam <sarumuga>
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/13111
    Reviewed-by: Kotresh HR <khiremat>
    Tested-by: Kotresh HR <khiremat>
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 36 Vijay Bellur 2016-05-17 09:02:33 UTC

REVIEW: http://review.gluster.org/14372 (glusterd/geo-rep: slave volume uuid to identify a geo-rep session) posted (#1) for review on release-3.8 by Saravanakumar Arumugam (sarumuga)

Note You need to log in before you can comment on or make changes to this bug.