Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/kf5-libkipi.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kf5/kf5-libkipi-15.12.0-1.fc23.src.rpm Description: Common plugin infrastructure for KDE image applications Fedora Account System Username: rdieter
rdieter's scratch build of kf5-libkipi-15.12.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12349155
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* BSD (3 clause)", "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated". 30 files have unknown license. Detailed output of licensecheck in /home/rpmbuild/1294839-kf5-libkipi/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/16x16, /usr/include/KF5, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor, /usr/lib64/cmake [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in kf5-libkipi [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kf5 -libkipi-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: kf5-libkipi-15.12.0-1.fc24.x86_64.rpm kf5-libkipi-devel-15.12.0-1.fc24.x86_64.rpm kf5-libkipi-debuginfo-15.12.0-1.fc24.x86_64.rpm kf5-libkipi-15.12.0-1.fc24.src.rpm kf5-libkipi.x86_64: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi kf5-libkipi-devel.x86_64: W: only-non-binary-in-usr-lib kf5-libkipi-devel.x86_64: W: no-documentation kf5-libkipi.src: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi 4 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: kf5-libkipi-debuginfo-15.12.0-1.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: File o directory non esistente kf5-libkipi-devel.x86_64: W: only-non-binary-in-usr-lib kf5-libkipi-devel.x86_64: W: no-documentation kf5-libkipi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Kipi.so.5.0.0 /lib64/libKF5ConfigWidgets.so.5 kf5-libkipi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Kipi.so.5.0.0 /lib64/libKF5Codecs.so.5 kf5-libkipi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Kipi.so.5.0.0 /lib64/libKF5ConfigGui.so.5 kf5-libkipi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Kipi.so.5.0.0 /lib64/libKF5Auth.so.5 kf5-libkipi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Kipi.so.5.0.0 /lib64/libQt5DBus.so.5 kf5-libkipi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Kipi.so.5.0.0 /lib64/libKF5WidgetsAddons.so.5 kf5-libkipi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Kipi.so.5.0.0 /lib64/libm.so.6 kf5-libkipi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Kipi.so.5.0.0 /lib64/libgcc_s.so.1 3 packages and 0 specfiles checked; 0 errors, 10 warnings. Requires -------- kf5-libkipi-debuginfo (rpmlib, GLIBC filtered): kf5-libkipi-devel (rpmlib, GLIBC filtered): kf5-kconfig-devel kf5-ki18n-devel kf5-kservice-devel kf5-kxmlgui-devel kf5-libkipi(x86-64) libKF5Kipi.so.30.0.0()(64bit) kf5-libkipi (rpmlib, GLIBC filtered): /bin/sh kf5-filesystem libKF5Auth.so.5()(64bit) libKF5Codecs.so.5()(64bit) libKF5ConfigCore.so.5()(64bit) libKF5ConfigGui.so.5()(64bit) libKF5ConfigWidgets.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5Service.so.5()(64bit) libKF5WidgetsAddons.so.5()(64bit) libKF5XmlGui.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.6)(64bit) libQt5DBus.so.5()(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- kf5-libkipi-debuginfo: kf5-libkipi-debuginfo kf5-libkipi-debuginfo(x86-64) kf5-libkipi-devel: cmake(KF5Kipi) kf5-libkipi-devel kf5-libkipi-devel(x86-64) kf5-libkipi: kf5-libkipi kf5-libkipi(x86-64) libKF5Kipi.so.30.0.0()(64bit) Source checksums ---------------- http://download.kde.org/stable/applications/15.12.0/src/libkipi-15.12.0.tar.xz : CHECKSUM(SHA256) this package : e1a1b82007829910284d542af98123b0ef060d252c90cf7a1ad35ee54e52ef10 CHECKSUM(SHA256) upstream package : e1a1b82007829910284d542af98123b0ef060d252c90cf7a1ad35ee54e52ef10 Generated by fedora-review 0.6.0 (7737a2a) last change: 2015-11-26 Command line :./FedoraReview/try-fedora-review -b 1294839 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package is set to be GPLv2+ but these files are LGPL: LGPL (v2 or later) ------------------ libkipi-15.12.0/src/libkipi_debug.cpp libkipi-15.12.0/src/libkipi_debug.h
GPLv2+ combined with LGPLv2+ is (still) effectively GPLv2+
In particular, I'm choosing to use the simplified effective license as referenced here: https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F
And it appears you may have set the wrong bugzilla flag: fedora_requires_release_note instead of fedora-review
Ok, so package is approved :-)
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/kf5-libkipi
Imported into rawhide, thanks.
kf5-libkipi-15.12.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ce83cb6a02
kf5-libkipi-15.12.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ce83cb6a02
kf5-libkipi-15.12.1-1.fc23 spectacle-15.12.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ce83cb6a02
kf5-libkipi-15.12.1-1.fc23, spectacle-15.12.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ce83cb6a02
kf5-libkipi-15.12.1-1.fc23, spectacle-15.12.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.