Spec URL: https://rbarlow.fedorapeople.org/erlang-p1_mysql.spec SRPM URL: https://rbarlow.fedorapeople.org/erlang-p1_mysql-0-1.20150929gitdfa87da9.fc24.src.rpm Description: This is an Erlang MySQL driver, used by ejabberd. Fedora Account System Username: rbarlow Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12361000 There are rpmlint warnings: Checking: erlang-p1_mysql-0-1.20150929gitdfa87da9.fc24.noarch.rpm erlang-p1_mysql-0-1.20150929gitdfa87da9.fc24.src.rpm erlang-p1_mysql.noarch: W: only-non-binary-in-usr-lib erlang-p1_mysql.noarch: W: no-documentation erlang-p1_mysql.src:43: W: libdir-macro-in-noarch-package (main package) %{_libdir}/erlang/lib/%{srcname}-%{version} 2 packages and 0 specfiles checked; 0 errors, 3 warnings. I think we can ignore these warnings. Erlang packages go into %{_libdir} by Fedora convention: https://fedoraproject.org/wiki/User:Peter/Erlang_Packaging_Guidelines Also, the upstream package does not have documentation.
rbarlow's scratch build of erlang-p1_mysql-0-1.20150929gitdfa87da9.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12441521
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/jcline/devel/fedora- review/1295011-erlang-p1_mysql/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: erlang-p1_mysql-0-1.20150929gitdfa87da9.fc24.x86_64.rpm erlang-p1_mysql-0-1.20150929gitdfa87da9.fc24.src.rpm erlang-p1_mysql.x86_64: W: spelling-error %description -l en_US ejabberd -> jabbered, jabberer, jabber erlang-p1_mysql.x86_64: E: no-binary erlang-p1_mysql.x86_64: W: only-non-binary-in-usr-lib erlang-p1_mysql.x86_64: W: no-documentation erlang-p1_mysql.src: W: spelling-error %description -l en_US ejabberd -> jabbered, jabberer, jabber 2 packages and 0 specfiles checked; 1 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory erlang-p1_mysql.x86_64: W: spelling-error %description -l en_US ejabberd -> jabbered, jabberer, jabber erlang-p1_mysql.x86_64: E: no-binary erlang-p1_mysql.x86_64: W: only-non-binary-in-usr-lib erlang-p1_mysql.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 1 errors, 3 warnings. Requires -------- erlang-p1_mysql (rpmlib, GLIBC filtered): erlang-erts Provides -------- erlang-p1_mysql: erlang-p1_mysql erlang-p1_mysql(x86-64) Source checksums ---------------- https://github.com/processone/mysql/archive/dfa87da95f8fdb92e270741c2a53f796b682f918.tar.gz : CHECKSUM(SHA256) this package : 285addc60b3433e5c2787de9e4670032593fe0515523776c49e130806090c751 CHECKSUM(SHA256) upstream package : 285addc60b3433e5c2787de9e4670032593fe0515523776c49e130806090c751 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1295011 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/erlang-p1_mysql
http://koji.fedoraproject.org/koji/taskinfo?taskID=12898299