Spec URL: https://fale.fedorapeople.org/aws/python-prompt_toolkit.spec SRPM URL: https://fale.fedorapeople.org/aws/python-prompt_toolkit-0.52-1.fc23.src.rpm Description: Library for building powerful interactive command lines in Python Fedora Account System Username: fale
*** Bug 1295103 has been marked as a duplicate of this bug. ***
Blockers: 1) Needs wcwidth which is not part for Fedora yet. 2) Why is LICENSE set to LICENSE.txt? Pick the valid and correct license from: https://fedoraproject.org/wiki/Licensing:Main 3) Fix rpmlint warning: python-prompt_toolkit.src:60: W: setup-not-quiet 4) Include AUTHORS.rst, CHANGELOG & TODO.rst in packages. Nice to fix: 1) Include the examples in -example subpackage. 2) Ask upstream to include license info in each source file. 3) No need for empty lines between Summary/ License, BuildArch&BuildReq. Package Review ============== Legend:[X] = Pass, [!] = Fail, [-] = Not applicable ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 128 files have unknown license. [X]: License file installed when any subpackage combination is installed. [X]: Package does not own files or directories owned by other packages. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [!]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [X]: Package complies to the Packaging Guidelines [X]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [X]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [X]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [X]: Package requires other packages for directories it uses. [X]: Package must own all directories that it creates. [X]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [X]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [X]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [X]: Macros in Summary, %description expandable at SRPM build time. [X]: Dist tag is present. [X]: Package does not contain duplicates in %files. [X]: Permissions on files are set properly. [-]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [X]: Package is named using only allowed ASCII characters. [X]: Package does not use a name that already exists. [X]: Package is not relocatable. [X]: Sources used to build the package match the upstream source, as provided in the spec URL. [X]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [X]: File names are valid UTF-8. [X]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [X]: Package contains BR: python2-devel or python3-devel [X]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-prompt_toolkit , python3-prompt_toolkit [X]: Package functions as described. [-]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [X]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [X]: Reviewer should test that the package builds in mock. [X]: Buildroot is not present [X]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [X]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [X]: SourceX is a working URL. [X]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. [X]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-prompt_toolkit-0.52-1.fc23.noarch.rpm python3-prompt_toolkit-0.52-1.fc23.noarch.rpm python-prompt_toolkit-0.52-1.fc23.src.rpm python2-prompt_toolkit.noarch: W: invalid-license LICENSE.txt python3-prompt_toolkit.noarch: W: invalid-license LICENSE.txt python-prompt_toolkit.src: W: invalid-license LICENSE.txt python-prompt_toolkit.src:60: W: setup-not-quiet 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- python2-prompt_toolkit (rpmlib, GLIBC filtered): python(abi) python-pygments python-six python-wcwidth python3-prompt_toolkit (rpmlib, GLIBC filtered): python(abi) python3-pygments python3-six python3-wcwidth Provides -------- python2-prompt_toolkit: python-prompt_toolkit python2-prompt_toolkit python3-prompt_toolkit: python3-prompt_toolkit Source checksums ---------------- https://pypi.python.org/packages/source/p/prompt_toolkit/prompt_toolkit-0.52.tar.gz : CHECKSUM(SHA256) this package : 35b8a34df8dea4cba92222dc1b8700c30ed7a8ba47cf3bc583768c5571a30902 CHECKSUM(SHA256) upstream package : 35b8a34df8dea4cba92222dc1b8700c30ed7a8ba47cf3bc583768c5571a30902
Thanks for the review :) Blockers: 1) Yeah, it's already blocking this one bug :) 2) Thanks, fixed [0] 3) Thanks, fixed [0] 4) Thanks, fixed [0] Nice to fix: 1) Thanks, I'll look to add it 2) I'll check the files and I'll fill the bug 3) Done, thanks :)[0] [0]: https://fale.fedorapeople.org/aws/python-prompt_toolkit.spec
Thanks! Package python-prompt_toolkit is APPROVED.
Thanks a lot :)
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-prompt_toolkit
python-prompt_toolkit-0.52-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8a6329eab5
python-prompt_toolkit-0.52-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f625ee2ba5
python-prompt_toolkit-0.52-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d0a73e9a0f
python-prompt_toolkit-0.52-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0a364f14aa
Hi again, I see latest prompt_toolkit release is version 0.57: https://pypi.python.org/pypi/prompt_toolkit any reason outdated 0.52 is used here?
@Terje: This package has a very rapid release cycle (the 0.55 was release on 03/01/2016, 0.56 on 03/01/2016 - yes, same day - and 0.57 on 04/01/2016). I've noticed that many applications have problems with 0.53+ (it seems like they broke some API between 0.52 and 0.53). I'll work on aws-cli to make it working properly on 0.57. IIRC, mycli required 0.42+ so it's also broken by the 0.53 release. I'll take a look at mycli too to see if I can help to make it work on 0.57 (hopeing it will last as last stable for at least a week).
Ok, I see. mycli @ github now requires 0.57: https://github.com/dbcli/mycli/commit/32e923c590d46b90e3a4ff2660354f803315867c A 0.57 release in fedora would be nice :-) Let's hope API changes slows down.
python-prompt_toolkit-0.52-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d0a73e9a0f
python-prompt_toolkit-0.52-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f625ee2ba5
Good point. I'll update it tomorow since: - mycli has been upgraded from prompt_toolkit 0.4x to 0.57 without any line of code change then the problem in aws-cli is (at least partially) - mycli is already been approved, aws-shell has some time before it can be packaged so it can be improved in upstream
python-prompt_toolkit-0.57-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-5f48cdcb92
python-prompt_toolkit-0.57-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-41f6e461a2
python-prompt_toolkit-0.52-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0a364f14aa
python-prompt_toolkit-0.52-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8a6329eab5
python-prompt_toolkit-0.57-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-41f6e461a2
python-prompt_toolkit-0.57-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-5f48cdcb92
python-prompt_toolkit-0.57-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-300412abda
python-prompt_toolkit-0.57-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-300412abda
python-prompt_toolkit-0.57-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
python-prompt_toolkit-0.57-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.