Spec URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/hawaii-workspace.spec SRPM URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/hawaii-workspace-0.5.0-1.fc23.src.rpm Description: Hawaii runtime components. Fedora Account System Username: plfiorini
plfiorini's scratch build of hawaii-workspace-0.5.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12432693
naming: ok sources: ok 8e29d8d69bf6ffe04177ad0907f395ff hawaii-workspace-0.5.0.tar.xz licensing: ok files: ok, but 1. the filelist is small, so SHOULD track files more closely instead of using globs everywhere, with something like: %files ... %{_bindir}/hawaii-polkit-agent %{_bindir}/hawaii-screenshot %{_sysconfdir}/xdg/hawaii-polkit-agent.desktop %{_datadir}/applications/org.hawaiios.screenshot.desktop 2. MUST validate all application .desktop files, adding BuildRequires: desktop-file-utils ... %check desktop-file-validate %{buildroot}%{_datadir}/applications/org.hawaiios.screenshot.desktop 3. SHOULD omit deprecated rpm tags Group: All in all, pretty simple and clean, only one mostly-cosmetic MUST blocker (2)... I'll leave it to you to add prior to doing any official builds. APPROVED.
> 1. the filelist is small, so SHOULD track files more closely instead of using globs everywhere, with something like: Done > 2. MUST validate all application .desktop files, adding Done > 3. SHOULD omit deprecated rpm tags > Group: Done, removed the Group tag Updated the spec and srpm Spec URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-workspace.spec SRPM URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-workspace-0.5.0-1.fc23.src.rpm
plfiorini's scratch build of hawaii-workspace-0.5.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12570615
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/hawaii-workspace