Hide Forgot
Spec URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/hawaii-system-preferences.spec SRPM URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/hawaii-system-preferences-0.5.0-1.fc23.src.rpm Description: This package contains configuration utilities for the Hawaii desktop, which allow to configure various settings including desktop fonts, keyboard and mouse properties, sound setup, desktop theme and background, user interface properties, screen resolution, and other settings. Fedora Account System Username: plfiorini
plfiorini's scratch build of hawaii-system-preferences-0.5.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12432770
With mixed licesing, you should provide a description in a comment in the spec file. -n %{name}-%{version} is the default for %setup. Spec file looks nice.
+ latest version + license is acceptable + license files are present, %license is used - I'm not convinced that the license is specified correctly + provides and requires look sane + no scriptlets present or necessary + description and name are OK Appdata file is not present, but I don't think it makes much sense to include it: this package will be installed as part of the desktop, and is useless otherwise. There is a desktop file, maybe add %check desktop-file-validate ... ? More of an upstream issue, please notify developers: DISPLAY= /usr/bin/hawaii-system-preferences QXcbConnection: Could not connect to display Aborted (core dumped) So the only notable issue is the licensing. Can you clarify which parts in the binary rpm are under which licenses?
License: Executable is GPL2+, preference applets are LGPL2.1+. Appdata: I didn't include it because it might be useless for other people. Actually I can check what gnome-control-center and systemsettings do. Desktop files: yes there are a bunch of desktop files, will add validation with the next iteration. Upstream issue: Yeah looks like a Qt issue, happens with other programs too.
(In reply to Pier Luigi Fiorini from comment #4) > License: Executable is GPL2+, preference applets are LGPL2.1+. OK. Please add a comment in the spec file. > Appdata: I didn't include it because it might be useless for other people. Right. That's what I said ;) > Actually I can check what gnome-control-center and systemsettings do. OK. Hm, gnome-control-center does have an appdata file. But gnome-software refuses to show it. It also fails validation. I'm not sure what the proper resolution is here. You might want to ask on fedora-devel. Either way, the package can go in without appdata.
Update: - License comment - Desktop file validation - Less globs Spec URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-system-preferences.spec SRPM URL: https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-system-preferences-0.5.0-1.fc23.src.rpm
plfiorini's scratch build of hawaii-system-preferences-0.5.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12667586
OK, no more issues. Package is APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/hawaii-system-preferences