Bug 1295406 - python-xdot: Provide a Python 3 subpackage
python-xdot: Provide a Python 3 subpackage
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: python-xdot (Show other bugs)
24
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Dave Malcolm
Fedora Extras Quality Assurance
:
Depends On:
Blocks: PYTHON3 PY3PATCH-AVAILABLE
  Show dependency treegraph
 
Reported: 2016-01-04 06:36 EST by Petr Viktorin
Modified: 2016-09-22 10:13 EDT (History)
3 users (show)

See Also:
Fixed In Version: python-xdot-0.7-1.fc26
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-09-22 10:13:41 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Switch to Python 3 (2.67 KB, patch)
2016-09-08 09:43 EDT, Dominika Krejčí
no flags Details | Diff
Switch to Python 3 (2.69 KB, patch)
2016-09-09 04:51 EDT, Dominika Krejčí
no flags Details | Diff
Switch to Python 3 (2.70 KB, patch)
2016-09-21 10:12 EDT, Dominika Krejčí
no flags Details | Diff

  None (edit)
Description Petr Viktorin 2016-01-04 06:36:08 EST
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's fine to do this in Rawhide only.


If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
Comment 1 Jan Kurik 2016-02-24 09:13:28 EST
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase
Comment 2 Dominika Krejčí 2016-04-20 05:02:10 EDT
Hello Dave,
Do you need any help adding Python 3 support to the RPM?

If you need more instructions, a [guide] for porting Python-based RPMs is
available.

[guide] http://python-rpm-porting.readthedocs.org/en/latest/index.html
Comment 3 Dominika Krejčí 2016-09-08 09:43 EDT
Created attachment 1199115 [details]
Switch to Python 3

Hello Dave,
there is a patch for update to the latest version and switch to Python 3. Could you please do the review and push it?

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15543119
Comment 4 Dominika Krejčí 2016-09-09 04:51 EDT
Created attachment 1199338 [details]
Switch to Python 3

Updating the patch. There was an issue with Python 2 requirements.
Comment 5 Dominika Krejčí 2016-09-09 04:52:18 EDT
+ Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15554384
Comment 6 Lumír Balhar 2016-09-09 04:58:27 EDT
Hello.

This patch looks good to me. If maintainer has nothing against, we can push this change after a week.

Have a nice day.
Comment 7 Dave Malcolm 2016-09-09 10:00:16 EDT
(In reply to Dominika Krejčí from comment #4)
> Created attachment 1199338 [details]
> Switch to Python 3
> 
> Updating the patch. There was an issue with Python 2 requirements.

Thanks.

One nit: in the %changelog:
  "Add Python 3"
should presumably be
  "Switch from Python 2 to Python 3"
or similar.

Other than, looks good to me.  If you have push rights, feel free to commit with that fixed.  Otherwise, would you like co-maintainership?
Comment 8 Dominika Krejčí 2016-09-21 10:12 EDT
Created attachment 1203330 [details]
Switch to Python 3

Hi Dave,
there is a patch with fixed changelog.
I haven't got a push rights and I am not interested in co-maintainership. Thank you.
Comment 9 Dave Malcolm 2016-09-22 10:13:41 EDT
Thanks.

Patch pushed (having uploaded new sources); built into rawhide here:
  http://koji.fedoraproject.org/koji/buildinfo?buildID=803590

Note You need to log in before you can comment on or make changes to this bug.