Bug 1295428 - VM memory usage is not reported correctly
Summary: VM memory usage is not reported correctly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: General
Version: 4.17.13
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-3.6.3
: 4.17.19
Assignee: Milan Zamazal
QA Contact: sefi litmanovich
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-04 13:15 UTC by Roman Hodain
Modified: 2016-02-18 11:18 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-02-18 11:18:05 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-3.6.z+
rule-engine: planning_ack+
tjelinek: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 51508 0 master MERGED virt: Don't expose GuestAgent.guestInfo directly 2016-01-18 00:44:47 UTC
oVirt gerrit 52335 0 ovirt-3.6 MERGED virt: Don't expose GuestAgent.guestInfo directly 2016-01-19 07:46:37 UTC

Description Roman Hodain 2016-01-04 13:15:34 UTC
Description of problem:
The VM memory usage is sometimes reported incorrectly.

Version-Release number of selected component (if applicable):
vdsm-4.17.13-1.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1.Run the following on the host where a VM with installed guest agent is running a couple of times in row:

     # vdsClient -s 0 getAllVmStats

2. The result is correct the first time. The second time is already incorrect.

Actual results:
Incorrect memory usage is reported

Expected results:
Correct memory usage is reported

Comment 2 Red Hat Bugzilla Rules Engine 2016-01-04 13:44:22 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 3 sefi litmanovich 2016-02-10 14:11:37 UTC
Verified with vdsm-4.17.19-0.el7ev.noarch according to description.
memUsage values didn't not change.

Comment 4 sefi litmanovich 2016-02-10 14:12:11 UTC
Verified with vdsm-4.17.19-0.el7ev.noarch according to description.
memUsage values didn't not change.

Comment 5 Roman Hodain 2016-02-17 12:36:52 UTC
Hi,

would it be possible to fix the code in https://bugzilla.redhat.com/show_bug.cgi?id=1295428#c1 ?

It is a bit confusing to handle a variable in this way.

Comment 6 Milan Zamazal 2016-02-18 08:35:57 UTC
(In reply to Roman Hodain from comment #5)
 
> would it be possible to fix the code in
> https://bugzilla.redhat.com/show_bug.cgi?id=1295428#c1 ?

I agree the code is not the best invention but we are a bit paranoid about possibly breaking things and/or backward compatibility. Renaming either input or output memUsage might be dangerous. Maybe we could duplicate input memUsage under a different name; then the new name could be used in _getGuestStats() and make the code cleaner while the old name would be still available in case it's used anywhere (yes, still not very nice).

Whatever you think is appropriate, feel free to post a patch to gerrit and we can discuss it there.

(The fix chosen for this bug is a safe fix of a general problem; improving _getGuestStats() is another issue.)


Note You need to log in before you can comment on or make changes to this bug.