Bug 1295428
| Summary: | VM memory usage is not reported correctly | ||
|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Roman Hodain <rhodain> |
| Component: | General | Assignee: | Milan Zamazal <mzamazal> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | sefi litmanovich <slitmano> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 4.17.13 | CC: | bugs, mzamazal, sbonazzo, tjelinek |
| Target Milestone: | ovirt-3.6.3 | Flags: | rule-engine:
ovirt-3.6.z+
rule-engine: planning_ack+ tjelinek: devel_ack+ rule-engine: testing_ack+ |
| Target Release: | 4.17.19 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Due to a bug in handling of internal Vdsm structures the reported VM memory usage value might be sometimes completely incorrect. This was fixed and the reported VM memory usage should be true now.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-18 11:18:05 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone. Verified with vdsm-4.17.19-0.el7ev.noarch according to description. memUsage values didn't not change. Verified with vdsm-4.17.19-0.el7ev.noarch according to description. memUsage values didn't not change. Hi, would it be possible to fix the code in https://bugzilla.redhat.com/show_bug.cgi?id=1295428#c1 ? It is a bit confusing to handle a variable in this way. (In reply to Roman Hodain from comment #5) > would it be possible to fix the code in > https://bugzilla.redhat.com/show_bug.cgi?id=1295428#c1 ? I agree the code is not the best invention but we are a bit paranoid about possibly breaking things and/or backward compatibility. Renaming either input or output memUsage might be dangerous. Maybe we could duplicate input memUsage under a different name; then the new name could be used in _getGuestStats() and make the code cleaner while the old name would be still available in case it's used anywhere (yes, still not very nice). Whatever you think is appropriate, feel free to post a patch to gerrit and we can discuss it there. (The fix chosen for this bug is a safe fix of a general problem; improving _getGuestStats() is another issue.) |
Description of problem: The VM memory usage is sometimes reported incorrectly. Version-Release number of selected component (if applicable): vdsm-4.17.13-1.el7ev.noarch How reproducible: 100% Steps to Reproduce: 1.Run the following on the host where a VM with installed guest agent is running a couple of times in row: # vdsClient -s 0 getAllVmStats 2. The result is correct the first time. The second time is already incorrect. Actual results: Incorrect memory usage is reported Expected results: Correct memory usage is reported