Bug 1296792 - Review Request: erlang-p1_stringprep - A framework for preparing Unicode strings to help input and comparison
Review Request: erlang-p1_stringprep - A framework for preparing Unicode stri...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Randy Barlow
Fedora Extras Quality Assurance
Depends On:
Blocks: 1204119
  Show dependency treegraph
Reported: 2016-01-07 23:14 EST by Jeremy Cline
Modified: 2016-02-09 17:28 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2016-02-09 17:28:16 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rbarlow: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Jeremy Cline 2016-01-07 23:14:07 EST
Spec URL: https://jcline.fedorapeople.org/erlang-p1_stringprep.spec
SRPM URL: https://jcline.fedorapeople.org/erlang-p1_stringprep-1.0.0-1.fc23.src.rpm
Stringprep is a framework for preparing Unicode test strings in order to
increase the likelihood that string input and string comparison work. The
principle are defined in RFC-3454: Preparation of Internationalized Strings.
This library is leverage Erlang native NIF mechanism to provide extremely fast
and efficient processing.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12460480
Comment 1 Randy Barlow 2016-01-24 15:38:58 EST
This package fails to install, I think due to requiring erlang-ert instead of erlang-erts.
Comment 3 Randy Barlow 2016-02-02 20:18:42 EST
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== rbarlow items =====

[!]: Consider using the %erllibdir macro instead of %{_libdir}/erlang/lib.
[!]: Add TCL to the license in the spec file. I think you can just write "ASL 2.0 and TCL" there.

===== MUST items =====

[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later) (with incorrect FSF address)", "Unknown or
     generated". 5 files have unknown license. Detailed output of
     licensecheck in /home/rbarlow/1296792-erlang-
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Checking: erlang-p1_stringprep-1.0.0-2.fc24.x86_64.rpm
erlang-p1_stringprep.x86_64: W: spelling-error %description -l en_US Stringprep -> String prep, String-prep, Stripping
erlang-p1_stringprep.x86_64: W: unstripped-binary-or-object /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so
erlang-p1_stringprep.x86_64: W: no-soname /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so
erlang-p1_stringprep.src: W: spelling-error %description -l en_US Stringprep -> String prep, String-prep, Stripping
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Rpmlint (installed packages)
sh: /usr/bin/python: No such file or directory
erlang-p1_stringprep.x86_64: W: spelling-error %description -l en_US Stringprep -> String prep, String-prep, Stripping
erlang-p1_stringprep.x86_64: W: unstripped-binary-or-object /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so
erlang-p1_stringprep.x86_64: W: no-soname /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so
erlang-p1_stringprep.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so enif_inspect_iolist_as_binary
erlang-p1_stringprep.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so enif_realloc_binary
erlang-p1_stringprep.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so enif_make_atom
erlang-p1_stringprep.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so enif_release_binary
erlang-p1_stringprep.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so enif_make_binary
erlang-p1_stringprep.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so enif_make_badarg
erlang-p1_stringprep.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so enif_alloc_binary
erlang-p1_stringprep.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so enif_alloc
erlang-p1_stringprep.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so enif_free
erlang-p1_stringprep.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so enif_realloc
1 packages and 0 specfiles checked; 0 errors, 13 warnings.

erlang-p1_stringprep (rpmlib, GLIBC filtered):


Unversioned so-files
erlang-p1_stringprep: /usr/lib64/erlang/lib/p1_stringprep-1.0.0/priv/lib/stringprep.so

Source checksums
https://github.com/processone/stringprep/archive/1.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : 5a74277e7bfb18b8f35838fa78fcde83f0acdb5b2a5b90c4b6d2470a33f7911e
  CHECKSUM(SHA256) upstream package : 5a74277e7bfb18b8f35838fa78fcde83f0acdb5b2a5b90c4b6d2470a33f7911e

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1296792
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Comment 4 Gwyn Ciesla 2016-02-03 12:43:33 EST
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/erlang-p1_stringprep

Note You need to log in before you can comment on or make changes to this bug.