Hide Forgot
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/22d5f18c5b41c7d4792b54dc112cf8027cc26cdc/php/php-mcnetic-zipstreamer/php-mcnetic-zipstreamer.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-mcnetic-zipstreamer-1.7-1.remi.src.rpm Description: Simple Class to create zip files on the fly and stream directly to the HTTP client as the content is added (without using temporary files). Autoloader: /usr/share/php/ZipStreamer/autoload.php Fedora Account System Username: remi -- Notices: - Dependency of owncloud. - as usually, I will cleanup EL-5 stuff after import.
I'm happy to take this for review - especially since it has a direct impact on my owncloud work.
remi's scratch build of php-mcnetic-zipstreamer-1.7-1.remi.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12465663
remi's scratch build of php-mcnetic-zipstreamer-1.7-2.remi.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12465855
It seems this library is not really clean... :( We have to ignore test on i386/arm for now. At least, another proof that unbundling is useful ;) Spec: https://raw.githubusercontent.com/remicollet/remirepo/94ad2fa705b18be2d1fd223c6b9a44289f0ab032/php/php-mcnetic-zipstreamer/php-mcnetic-zipstreamer.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-mcnetic-zipstreamer-1.7-2.remi.src.rpm
James -- Hopefully you won't mind me taking this review? I did the review before realizing you had initially took it.
Created attachment 1116504 [details] phpcompatinfo-full.log phpCompatInfo version 4.5.2 DB built Nov 26 2015 14:29:15 CET
Created attachment 1116505 [details] phpcompatinfo-lib.log phpCompatInfo version 4.5.2 DB built Nov 26 2015 14:29:15 CET
Created attachment 1116506 [details] fedora-review.txt Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1296901 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
[!]: Latest version is packaged. Latest version is 0.7, not 1.7
Damn... Good catch... https://github.com/remicollet/remirepo/commit/8f9c12fbc6d0343d370531f9fa9bfe8f61797463 Spec: https://raw.githubusercontent.com/remicollet/remirepo/8f9c12fbc6d0343d370531f9fa9bfe8f61797463/php/php-mcnetic-zipstreamer/php-mcnetic-zipstreamer.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-mcnetic-zipstreamer-0.7-1.remi.src.rpm
[x]: Latest version is packaged. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required As usual, remove EPEL 5 bits after initial import No blockers. ===== APPROVED =====
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-mcnetic-zipstreamer
php-mcnetic-zipstreamer-0.7-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f2107c60da
php-mcnetic-zipstreamer-0.7-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-20a57d7c40
php-mcnetic-zipstreamer-0.7-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-76e744099f
php-mcnetic-zipstreamer-0.7-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-20a57d7c40
php-mcnetic-zipstreamer-0.7-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f2107c60da
php-mcnetic-zipstreamer-0.7-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-76e744099f
php-mcnetic-zipstreamer-0.7-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
php-mcnetic-zipstreamer-0.7-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
php-mcnetic-zipstreamer-0.7-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.