Spec URL: https://jcline.fedorapeople.org/erlang-p1_xml.spec SRPM URL: https://jcline.fedorapeople.org/erlang-p1_xml-1.1.1-1.fc23.src.rpm Description: Fast Expat based Erlang XML parsing and manipulation library, with a strong focus on XML stream parsing from network. It supports full XML structure parsing, suitable for small but complete XML chunks, and XML stream parsing suitable for large XML document, or infinite network XML stream like XMPP. This module can parse files much faster than built-in module xmerl. Depending on file complexity and size xml_stream:parse_element/1 can be 8-18 times faster than calling xmerl_scan:string/2. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12488700
jcline's scratch build of erlang-p1_xml-1.1.1-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12488700
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/rbarlow/1297150 -erlang-p1_xml/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: erlang-p1_xml-1.1.1-1.fc24.x86_64.rpm erlang-p1_xml-1.1.1-1.fc24.src.rpm erlang-p1_xml.x86_64: W: spelling-error %description -l en_US xmerl -> Merle erlang-p1_xml.x86_64: W: spelling-error %description -l en_US xml -> XML, ml, x ml erlang-p1_xml.x86_64: W: unstripped-binary-or-object /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so erlang-p1_xml.x86_64: W: no-soname /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so erlang-p1_xml.x86_64: W: unstripped-binary-or-object /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so erlang-p1_xml.x86_64: W: no-soname /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so erlang-p1_xml.src: W: spelling-error %description -l en_US xmerl -> Merle erlang-p1_xml.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml 2 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory erlang-p1_xml.x86_64: W: spelling-error %description -l en_US xmerl -> Merle erlang-p1_xml.x86_64: W: spelling-error %description -l en_US xml -> XML, ml, x ml erlang-p1_xml.x86_64: W: unstripped-binary-or-object /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so erlang-p1_xml.x86_64: W: no-soname /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_alloc_binary erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_free erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_make_binary erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_make_atom erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_alloc erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_compare erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_get_tuple erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_realloc erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_make_badarg erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_inspect_iolist_as_binary erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_get_list_cell erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so enif_is_empty_list erlang-p1_xml.x86_64: W: unused-direct-shlib-dependency /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so /lib64/libexpat.so.1 erlang-p1_xml.x86_64: W: unstripped-binary-or-object /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so erlang-p1_xml.x86_64: W: no-soname /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_alloc_binary erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_free erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_free erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_inspect_binary erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_get_ulong erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_realloc_binary erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_make_new_binary erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_make_binary erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_send erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_make_atom erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_alloc erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_alloc erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_clear_env erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_compare erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_make_uint erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_free_env erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_get_local_pid erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_make_list_cell erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_release_binary erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_make_tuple erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_alloc_resource erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_release_resource erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_get_resource erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_make_badarg erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_alloc_env erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_make_resource erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_open_resource_type erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_make_list erlang-p1_xml.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so enif_realloc 1 packages and 0 specfiles checked; 0 errors, 48 warnings. Requires -------- erlang-p1_xml (rpmlib, GLIBC filtered): erlang-erts erlang-p1_utils libc.so.6()(64bit) libexpat.so.1()(64bit) rtld(GNU_HASH) Provides -------- erlang-p1_xml: erlang-p1_xml erlang-p1_xml(x86-64) Unversioned so-files -------------------- erlang-p1_xml: /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml.so erlang-p1_xml: /usr/lib64/erlang/lib/p1_xml-1.1.1/priv/lib/xml_stream.so Source checksums ---------------- https://github.com/processone/xml/archive/1.1.1.tar.gz : CHECKSUM(SHA256) this package : 4c163c5b9572baa93eb97e03544db57dc751c7995a5279081a0d56f5fdaa2521 CHECKSUM(SHA256) upstream package : 4c163c5b9572baa93eb97e03544db57dc751c7995a5279081a0d56f5fdaa2521 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1297150 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/erlang-p1_xml