Created attachment 1113333 [details] engine.log Description of problem: While having a quota configured for specific storage domains in the DC, disk creation on other domain in the same DC, that doesn't have quota configured, cannot be performed since the quota field is mandatory for it. Reproduced over REST and Webadmin. Version-Release number of selected component (if applicable): rhevm-3.6.2-0.1.el6.noarch How reproducible: 100% Steps to Reproduce: 1. On a DC with more than 1 storage domains (storage type doesn't matter). 2. Create a quota on the DC for a specific storage domain. Enable the quota for the DC by configure it to enforcing. 3. Initiate disk creation on the storage domain that doesn't have quota configured. Don't specify quota for the the add disk call. For example: <disk> <interface>virtio</interface> <format>raw</format> <provisioned_size>10737418240</provisioned_size> <alias>rest</alias> <storage_domains><storage_domain><name>data1</name></storage_domain></storage_domains> </disk> Actual results: Disk creation is blocked, engine informs that the creation call should be passed with quota: <fault> <reason>Operation Failed</reason> <detail> [Cannot add Virtual Machine Disk. Quota is not valid.] </detail> </fault> This domain doesn't have quota configured, the quota is configured for another domain in the DC: #select quota_id,storage_name from quota_storage_view; quota_id | storage_name --------------------------------------+-------------- 361089b7-f310-412b-84aa-5ab53d6778bb | data2 361089b7-f310-412b-84aa-5ab53d6778bb | data3 (2 rows) Domain 'data1' doesn't have a quota. Disk creation is not allowed on that domain. Expected results: For storage domains in a DC, where quota is configured for specific storage domains, which doesn't have quota configured, quota should not be required when creation a disk on them. Additional info: engine.log 2016-01-10 15:35:14,047 WARN [org.ovirt.engine.core.bll.AddDiskCommand] (ajp-/127.0.0.1:8702-5) [51eddfe8] CanDoAction of action 'AddDisk' failed for user admin@internal. Reasons: VAR__ACTION__ADD,VAR__TYPE__VM_DISK,ACTION_TYPE_FAILED_QUOTA_IS_NOT_VALID,$VmName null
Roy, this is a quota issue, not an add-disk issue. Can someone from your team please take a look?
Moran, we don't have a 'default' quota behavior. What do you want to happen here?
ignore comment 5. This is a real blocker.
Should we allow creating disks without quota? Similarly to creating disk profiles without QoS.
(In reply to Andrej Krejcir from comment #7) > Should we allow creating disks without quota? Similarly to creating disk > profiles without QoS. I think behaviour should stay the same. since if a user selected enforcing quota on a DC, all entities under it should include it.
Lets treat null or non existing quota as unlimited. This is I think the least surprising effect of not configuring quota on domain.
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.
verified on : oVirt Engine Version: 4.2.0-0.0.master.20161219225535.git893d571.el7.centos Verification steps: Steps to Reproduce: 1. On a DC with more than 1 storage domains (storage type doesn't matter). 2. Create a quota on the DC for a specific storage domain. Enable the quota for the DC by configure it to enforcing. 3. Initiate disk creation on the storage domain that doesn't have quota configured. Don't specify quota for the the add disk call. For example: <disk> <interface>virtio</interface> <format>raw</format> <provisioned_size>10737418240</provisioned_size> <alias>rest</alias> <storage_domains><storage_domain><name>data1</name></storage_domain></storage_domains> </disk>