Bug 1298180 - Review Request: python-libcnml - a CNML parser library for Python
Summary: Review Request: python-libcnml - a CNML parser library for Python
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Alessandro Locati
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1301268
TreeView+ depends on / blocked
 
Reported: 2016-01-13 12:15 UTC by Germano Massullo
Modified: 2016-02-23 01:25 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-23 01:25:11 UTC
Type: Bug
Embargoed:
fale: fedora-review+


Attachments (Terms of Use)

Description Germano Massullo 2016-01-13 12:15:27 UTC
Spec URL: https://germano.fedorapeople.org/package_reviews/python-libcnml/review_request/python-libcnml.spec

SRPM URL (GPG signed): https://germano.fedorapeople.org/package_reviews/python-libcnml/review_request/python-libcnml-0.9.3-1.fc23.src.rpm

SRPM URL (EsteID signed): https://germano.fedorapeople.org/package_reviews/python-libcnml/review_request/python-libcnml-0.9.3-1.fc23.src.bdoc

Description: Community Network Mark Up Language (CNML) is a project that aims to define an open ISO standard and scalable for describing mesh clouds, though it's not limited to this kind of networks and nowadays it's being used also in point to point infrastructure networks.
CNML is a specification based on XML, which makes it easily extendible and readable for humans besides of computers. It includes some ideas from other implementations and previous concepts like nodeXchange and SNDX.
Some advantages of using CNML is that it allows to uncouple different functionalities independently of the web application used to show the data, reducing dependence from it and its internal tables of the database.

Fedora Account System Username: germano
GPG key id: A903090E
EsteID (DIGI-ID E-RESIDENT) serial number 38601270070

Comment 1 Fabio Alessandro Locati 2016-01-13 18:44:53 UTC
Few preliminary comments:

1. libcnml/libcnml.py should be executable or without shabang (probably the former)

2. The chengelog is needed

Comment 2 Germano Massullo 2016-01-23 00:15:42 UTC
(In reply to Fabio Alessandro Locati from comment #1)
> Few preliminary comments:
> 
> 1. libcnml/libcnml.py should be executable or without shabang (probably the
> former)
> 
> 2. The chengelog is needed

1. just fixed upstream [1]
2. I am going to add it now.

If there is nothing else, I proceed with the creation of a new SRPM file

[1]: https://github.com/PabloCastellano/libcnml/issues/17

Comment 3 Germano Massullo 2016-01-23 10:12:29 UTC
Added macros to allow EPEL7 support

Comment 4 Fabio Alessandro Locati 2016-01-24 20:51:45 UTC
1. This is not solved by upstream commit, since the version you are packaging does not include that commit

2. Please, do fix your changelog. If the package version and release are 0.9.3-1, you can not have a changelog entry for 2.2.1-1

3. The current spec does not compile (see http://koji.fedoraproject.org/koji/taskinfo?taskID=12670254). It requires python2-six and python3-six as BuildRequire since you are running the tests.

4. Even adding python2-six and python3-six as for 3., some checks for python3 fails, at least on my machine.

Comment 5 Germano Massullo 2016-01-25 20:51:55 UTC
(In reply to Fabio Alessandro Locati from comment #4)
> 1. This is not solved by upstream commit, since the version you are
> packaging does not include that commit
> 
> 2. Please, do fix your changelog. If the package version and release are
> 0.9.3-1, you can not have a changelog entry for 2.2.1-1
> 
> 3. The current spec does not compile (see
> http://koji.fedoraproject.org/koji/taskinfo?taskID=12670254). It requires
> python2-six and python3-six as BuildRequire since you are running the tests.
> 
> 4. Even adding python2-six and python3-six as for 3., some checks for
> python3 fails, at least on my machine.

==== STATUS AND COMMENTS ====
1. TODO
2. DONE
3 & 4. NEEDINFO Could you please test it against F23? I successfully created the package

Comment 6 Germano Massullo 2016-01-25 22:43:25 UTC
==== STATUS AND COMMENTS ====
1. TODO
2. DONE
3. DONE
4. ALWAYS WORKED

updated spec and src.rpm files. URLs at first message

Comment 7 Germano Massullo 2016-01-25 22:46:55 UTC
==== STATUS AND COMMENTS ====
4. FAILED, koji build fails. I am going to check

Comment 8 Germano Massullo 2016-01-25 23:45:14 UTC
from my last koji build


running test
Searching for six
Reading https://pypi.python.org/simple/six/
Download error on https://pypi.python.org/simple/six/: [Errno -3] Temporary failure in name resolution -- Some packages may not be found!
Scanning index of all packages (this may take a while)
Couldn't find index page for 'six' (maybe misspelled?)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -3] Temporary failure in name resolution -- Some packages may not be found!
No local packages or download links found for six
error: Could not find suitable distribution for Requirement.parse('six')
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.NSubMK (%check)
    Bad exit status from /var/tmp/rpm-tmp.NSubMK (%check)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target noarch --nodeps  /builddir/build/SPECS/python-libcnml.spec 
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.4/site-packages/mockbuild/util.py", line 526, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
mockbuild.exception.Error: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target noarch --nodeps  /builddir/build/SPECS/python-libcnml.spec 
LEAVE do --> EXCEPTION RAISED

Comment 9 Germano Massullo 2016-01-26 15:18:03 UTC
added BuildRequire python-six but the tests still fail


[...]

======================================================================
ERROR: test_findNodefromIPv4 (libcnml.tests.test_libcnml.LibcnmlUrlTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/tests/test_libcnml.py", line 156, in setUp
    self.parser = libcnml.CNMLParser(self.cnml_url)
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 707, in __init__
    self.loaded = self.load()
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 1001, in load
    self.url_contents = request.urlopen(self.filename).read()
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
    return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 213, in open
    return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 443, in open_https
    h.endheaders(data)
  File "/usr/lib64/python2.7/httplib.py", line 1049, in endheaders
    self._send_output(message_body)
  File "/usr/lib64/python2.7/httplib.py", line 893, in _send_output
    self.send(msg)
  File "/usr/lib64/python2.7/httplib.py", line 855, in send
    self.connect()
  File "/usr/lib64/python2.7/httplib.py", line 1266, in connect
    HTTPConnection.connect(self)
  File "/usr/lib64/python2.7/httplib.py", line 832, in connect
    self.timeout, self.source_address)
  File "/usr/lib64/python2.7/socket.py", line 557, in create_connection
    for res in getaddrinfo(host, port, 0, SOCK_STREAM):
IOError: [Errno socket error] [Errno -3] Temporary failure in name resolution
======================================================================
ERROR: test_getDevices (libcnml.tests.test_libcnml.LibcnmlUrlTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/tests/test_libcnml.py", line 156, in setUp
    self.parser = libcnml.CNMLParser(self.cnml_url)
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 707, in __init__
    self.loaded = self.load()
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 1001, in load
    self.url_contents = request.urlopen(self.filename).read()
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
    return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 213, in open
    return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 443, in open_https
    h.endheaders(data)
  File "/usr/lib64/python2.7/httplib.py", line 1049, in endheaders
    self._send_output(message_body)
  File "/usr/lib64/python2.7/httplib.py", line 893, in _send_output
    self.send(msg)
  File "/usr/lib64/python2.7/httplib.py", line 855, in send
    self.connect()
  File "/usr/lib64/python2.7/httplib.py", line 1266, in connect
    HTTPConnection.connect(self)
  File "/usr/lib64/python2.7/httplib.py", line 832, in connect
    self.timeout, self.source_address)
  File "/usr/lib64/python2.7/socket.py", line 557, in create_connection
    for res in getaddrinfo(host, port, 0, SOCK_STREAM):
IOError: [Errno socket error] [Errno -3] Temporary failure in name resolution
======================================================================
ERROR: test_getInterfaces (libcnml.tests.test_libcnml.LibcnmlUrlTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/tests/test_libcnml.py", line 156, in setUp
    self.parser = libcnml.CNMLParser(self.cnml_url)
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 707, in __init__
    self.loaded = self.load()
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 1001, in load
    self.url_contents = request.urlopen(self.filename).read()
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
    return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 213, in open
    return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 443, in open_https
    h.endheaders(data)
  File "/usr/lib64/python2.7/httplib.py", line 1049, in endheaders
    self._send_output(message_body)
  File "/usr/lib64/python2.7/httplib.py", line 893, in _send_output
    self.send(msg)
  File "/usr/lib64/python2.7/httplib.py", line 855, in send
    self.connect()
  File "/usr/lib64/python2.7/httplib.py", line 1266, in connect
    HTTPConnection.connect(self)
  File "/usr/lib64/python2.7/httplib.py", line 832, in connect
    self.timeout, self.source_address)
  File "/usr/lib64/python2.7/socket.py", line 557, in create_connection
    for res in getaddrinfo(host, port, 0, SOCK_STREAM):
IOError: [Errno socket error] [Errno -3] Temporary failure in name resolution
======================================================================
ERROR: test_getLinks (libcnml.tests.test_libcnml.LibcnmlUrlTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/tests/test_libcnml.py", line 156, in setUp
    self.parser = libcnml.CNMLParser(self.cnml_url)
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 707, in __init__
    self.loaded = self.load()
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 1001, in load
    self.url_contents = request.urlopen(self.filename).read()
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
    return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 213, in open
    return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 443, in open_https
    h.endheaders(data)
  File "/usr/lib64/python2.7/httplib.py", line 1049, in endheaders
    self._send_output(message_body)
  File "/usr/lib64/python2.7/httplib.py", line 893, in _send_output
    self.send(msg)
  File "/usr/lib64/python2.7/httplib.py", line 855, in send
    self.connect()
  File "/usr/lib64/python2.7/httplib.py", line 1266, in connect
    HTTPConnection.connect(self)
  File "/usr/lib64/python2.7/httplib.py", line 832, in connect
    self.timeout, self.source_address)
  File "/usr/lib64/python2.7/socket.py", line 557, in create_connection
    for res in getaddrinfo(host, port, 0, SOCK_STREAM):
IOError: [Errno socket error] [Errno -3] Temporary failure in name resolution
======================================================================
ERROR: test_getNodes (libcnml.tests.test_libcnml.LibcnmlUrlTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/tests/test_libcnml.py", line 156, in setUp
    self.parser = libcnml.CNMLParser(self.cnml_url)
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 707, in __init__
    self.loaded = self.load()
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 1001, in load
    self.url_contents = request.urlopen(self.filename).read()
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
    return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 213, in open
    return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 443, in open_https
    h.endheaders(data)
  File "/usr/lib64/python2.7/httplib.py", line 1049, in endheaders
    self._send_output(message_body)
  File "/usr/lib64/python2.7/httplib.py", line 893, in _send_output
    self.send(msg)
  File "/usr/lib64/python2.7/httplib.py", line 855, in send
    self.connect()
  File "/usr/lib64/python2.7/httplib.py", line 1266, in connect
    HTTPConnection.connect(self)
  File "/usr/lib64/python2.7/httplib.py", line 832, in connect
    self.timeout, self.source_address)
  File "/usr/lib64/python2.7/socket.py", line 557, in create_connection
    for res in getaddrinfo(host, port, 0, SOCK_STREAM):
IOError: [Errno socket error] [Errno -3] Temporary failure in name resolution
======================================================================
ERROR: test_getRadios (libcnml.tests.test_libcnml.LibcnmlUrlTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/tests/test_libcnml.py", line 156, in setUp
    self.parser = libcnml.CNMLParser(self.cnml_url)
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 707, in __init__
    self.loaded = self.load()
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 1001, in load
    self.url_contents = request.urlopen(self.filename).read()
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
    return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 213, in open
    return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 443, in open_https
    h.endheaders(data)
  File "/usr/lib64/python2.7/httplib.py", line 1049, in endheaders
    self._send_output(message_body)
  File "/usr/lib64/python2.7/httplib.py", line 893, in _send_output
    self.send(msg)
  File "/usr/lib64/python2.7/httplib.py", line 855, in send
    self.connect()
  File "/usr/lib64/python2.7/httplib.py", line 1266, in connect
    HTTPConnection.connect(self)
  File "/usr/lib64/python2.7/httplib.py", line 832, in connect
    self.timeout, self.source_address)
  File "/usr/lib64/python2.7/socket.py", line 557, in create_connection
    for res in getaddrinfo(host, port, 0, SOCK_STREAM):
IOError: [Errno socket error] [Errno -3] Temporary failure in name resolution
======================================================================
ERROR: test_getServices (libcnml.tests.test_libcnml.LibcnmlUrlTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/tests/test_libcnml.py", line 156, in setUp
    self.parser = libcnml.CNMLParser(self.cnml_url)
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 707, in __init__
    self.loaded = self.load()
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 1001, in load
    self.url_contents = request.urlopen(self.filename).read()
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
    return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 213, in open
    return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 443, in open_https
    h.endheaders(data)
  File "/usr/lib64/python2.7/httplib.py", line 1049, in endheaders
    self._send_output(message_body)
  File "/usr/lib64/python2.7/httplib.py", line 893, in _send_output
    self.send(msg)
  File "/usr/lib64/python2.7/httplib.py", line 855, in send
    self.connect()
  File "/usr/lib64/python2.7/httplib.py", line 1266, in connect
    HTTPConnection.connect(self)
  File "/usr/lib64/python2.7/httplib.py", line 832, in connect
    self.timeout, self.source_address)
  File "/usr/lib64/python2.7/socket.py", line 557, in create_connection
    for res in getaddrinfo(host, port, 0, SOCK_STREAM):
IOError: [Errno socket error] [Errno -3] Temporary failure in name resolution
======================================================================
ERROR: test_getZones (libcnml.tests.test_libcnml.LibcnmlUrlTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/tests/test_libcnml.py", line 156, in setUp
    self.parser = libcnml.CNMLParser(self.cnml_url)
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 707, in __init__
    self.loaded = self.load()
  File "/builddir/build/BUILD/libcnml-0.9.3/libcnml/libcnml.py", line 1001, in load
    self.url_contents = request.urlopen(self.filename).read()
  File "/usr/lib64/python2.7/urllib.py", line 87, in urlopen
    return opener.open(url)
  File "/usr/lib64/python2.7/urllib.py", line 213, in open
    return getattr(self, name)(url)
  File "/usr/lib64/python2.7/urllib.py", line 443, in open_https
    h.endheaders(data)
  File "/usr/lib64/python2.7/httplib.py", line 1049, in endheaders
    self._send_output(message_body)
  File "/usr/lib64/python2.7/httplib.py", line 893, in _send_output
    self.send(msg)
  File "/usr/lib64/python2.7/httplib.py", line 855, in send
    self.connect()
  File "/usr/lib64/python2.7/httplib.py", line 1266, in connect
    HTTPConnection.connect(self)
  File "/usr/lib64/python2.7/httplib.py", line 832, in connect
    self.timeout, self.source_address)
  File "/usr/lib64/python2.7/socket.py", line 557, in create_connection
    for res in getaddrinfo(host, port, 0, SOCK_STREAM):
IOError: [Errno socket error] [Errno -3] Temporary failure in name resolution
----------------------------------------------------------------------
Ran 47 tests in 0.647s
FAILED (errors=8)
error: Bad exit status from /var/tmp/rpm-tmp.AhL55S (%check)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.AhL55S (%check)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target noarch --nodeps  /builddir/build/SPECS/python-libcnml.spec 
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.4/site-packages/mockbuild/util.py", line 526, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
mockbuild.exception.Error: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target noarch --nodeps  /builddir/build/SPECS/python-libcnml.spec 
LEAVE do --> EXCEPTION RAISED

Comment 10 Germano Massullo 2016-01-26 23:58:32 UTC
https://github.com/PabloCastellano/libcnml/issues/18

Comment 11 Germano Massullo 2016-01-27 10:23:32 UTC
libcnml does not block responses and viceversa

Comment 13 Germano Massullo 2016-01-31 15:59:42 UTC
Koji build works http://koji.fedoraproject.org/koji/taskinfo?taskID=12759124

Comment 14 Fabio Alessandro Locati 2016-02-05 11:11:38 UTC
Very good, the package is APPROVED. Remember to re-enable the checks as soon as the network connection problem is fixed upstream.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v3 or later)", "Unknown or generated". 6 files have
     unknown license. Detailed output of licensecheck in
     /home/fale/Downloads/python-libcnml/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-libcnml , python3-libcnml
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python2-libcnml-0.9.4-1.fc23.noarch.rpm
          python3-libcnml-0.9.4-1.fc23.noarch.rpm
          python-libcnml-0.9.4-1.fc23.src.rpm
python2-libcnml.noarch: W: summary-not-capitalized C libcnml is a CNML parser library for Python
python2-libcnml.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
python2-libcnml.noarch: W: spelling-error %description -l en_US extendible -> extensible, extendable, vendible
python2-libcnml.noarch: W: spelling-error %description -l en_US nodeXchange -> nod Exchange, nod-exchange, exchange
python2-libcnml.noarch: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist
python2-libcnml.noarch: E: zero-length /usr/lib/python2.7/site-packages/libcnml/tests/data/empty.cnml
python3-libcnml.noarch: W: summary-not-capitalized C libcnml is a CNML parser library for Python
python3-libcnml.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
python3-libcnml.noarch: W: spelling-error %description -l en_US extendible -> extensible, extendable, vendible
python3-libcnml.noarch: W: spelling-error %description -l en_US nodeXchange -> nod Exchange, nod-exchange, exchange
python3-libcnml.noarch: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist
python3-libcnml.noarch: E: zero-length /usr/lib/python3.4/site-packages/libcnml/tests/data/empty.cnml
python-libcnml.src: W: summary-not-capitalized C libcnml is a CNML parser library for Python
python-libcnml.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
python-libcnml.src: W: spelling-error %description -l en_US extendible -> extensible, extendable, vendible
python-libcnml.src: W: spelling-error %description -l en_US nodeXchange -> nod Exchange, nod-exchange, exchange
python-libcnml.src: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist
python-libcnml.src:100: W: macro-in-comment %check
python-libcnml.src:101: W: macro-in-comment %{__python2}
python-libcnml.src:103: W: macro-in-comment %{__python3}
python-libcnml.src:104: W: macro-in-comment %endif
python-libcnml.src:44: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 44)
3 packages and 0 specfiles checked; 2 errors, 20 warnings.




Rpmlint (installed packages)
----------------------------
python2-libcnml.noarch: W: summary-not-capitalized C libcnml is a CNML parser library for Python
python2-libcnml.noarch: W: invalid-url URL: https://github.com/PabloCastellano/libcnml <urlopen error [Errno -3] Temporary failure in name resolution>
python2-libcnml.noarch: E: zero-length /usr/lib/python2.7/site-packages/libcnml/tests/data/empty.cnml
python3-libcnml.noarch: W: summary-not-capitalized C libcnml is a CNML parser library for Python
python3-libcnml.noarch: W: invalid-url URL: https://github.com/PabloCastellano/libcnml <urlopen error [Errno -3] Temporary failure in name resolution>
python3-libcnml.noarch: E: zero-length /usr/lib/python3.4/site-packages/libcnml/tests/data/empty.cnml
2 packages and 0 specfiles checked; 2 errors, 4 warnings.



Requires
--------
python2-libcnml (rpmlib, GLIBC filtered):
    python(abi)
    python2-six

python3-libcnml (rpmlib, GLIBC filtered):
    python(abi)
    python3-six



Provides
--------
python2-libcnml:
    python-libcnml
    python2-libcnml

python3-libcnml:
    python3-libcnml



Source checksums
----------------
https://pypi.python.org/packages/source/l/libcnml/libcnml-0.9.4.tar.gz :
  CHECKSUM(SHA256) this package     : 700dbad28b8b40dd8132dfcdaa598777f34fbff4368a5f904d4d6490c1142995
  CHECKSUM(SHA256) upstream package : 700dbad28b8b40dd8132dfcdaa598777f34fbff4368a5f904d4d6490c1142995

Comment 15 Gwyn Ciesla 2016-02-05 16:22:33 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-libcnml

Comment 16 Fedora Update System 2016-02-06 08:00:58 UTC
python-libcnml-0.9.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-107691ff35

Comment 17 Fedora Update System 2016-02-07 07:22:35 UTC
python-libcnml-0.9.4-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-107691ff35

Comment 18 Fedora Update System 2016-02-23 01:25:09 UTC
python-libcnml-0.9.4-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.