Bug 1298697 - The engine let the user remove the last regular storage domain
Summary: The engine let the user remove the last regular storage domain
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.HostedEngine
Version: 3.6.1.3
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ovirt-3.6.3
: 3.6.3.1
Assignee: Roy Golan
QA Contact: Artyom
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-14 18:27 UTC by Simone Tiraboschi
Modified: 2018-01-11 06:37 UTC (History)
10 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-02-18 11:07:29 UTC
oVirt Team: SLA
Embargoed:
rule-engine: ovirt-3.6.z+
rule-engine: blocker+
mgoldboi: planning_ack+
dfediuck: devel_ack+
mavital: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 52351 0 master MERGED core: hosted engine: Avoid choosing the hosted engine sd as master 2021-01-14 11:15:53 UTC
oVirt gerrit 52844 0 ovirt-engine-3.6 MERGED core: hosted engine: Avoid choosing the hosted engine sd as master 2021-01-14 11:15:52 UTC
oVirt gerrit 53208 0 ovirt-engine-3.6.3 MERGED core: hosted engine: Avoid choosing the hosted engine sd as master 2021-01-14 11:15:53 UTC

Description Simone Tiraboschi 2016-01-14 18:27:13 UTC
Description of problem:
The engine let the user remove the last regular storage domain.
Hosted-engine storage domain becomes the master storage domain.

After a reboot it's not possible to add again another regular storage domain:
Error while executing action: Failed to activate Storage due to an error on the Data Center master Storage Domain.
-Please activate the master Storage Domain first.


Version-Release number of selected component (if applicable):
3.6.1.3

How reproducible:
100%

Steps to Reproduce:
1. deploy hosted-engine
2. add the first regular storage domain
3. let the engine import the hosted-engine storage domain
4. remove the regular storage domain
5. reboot

Actual results:
The engine let the user remove the last regular storage domain (the hosted engine one is here but it's a special one) and the hosted-engine storage domain become the master storage domain.
This prevent further storage actions after a reboot since we have no SPM.

Expected results:
the engine doesn't allow the user to remove the last regular storage domain (the hosted-engine one is not a regular storage domain)

Additional info:

Comment 3 Artyom 2016-02-17 16:44:08 UTC
Verified on rhevm-3.6.3.1-0.1.el6.noarch
Now not possible to remove master storage domain if engine has only additional HE storage domain, but from the patch I can see, that check depends on HE storage domain name, so if we will change via engine-config
engine-config -s HostedEngineStorageDomainName=he_storage we will encounter again the same problem
Maybe it is better to add some additional flag to storage domain table in database, is_he_storage_domain, true or false


Note You need to log in before you can comment on or make changes to this bug.