Created attachment 1115178 [details] full skyring.log file Description of problem ====================== Skyring crashes when mongod service is not running. While I understand that skyring requires mongodb to function properly, null pointer error crash of skyring process is an unacceptable way to handle this kind error state. Version-Release number of selected component ============================================ # rpm -qa | grep rhscon rhscon-ui-0.0.6-0.1.alpha1.el7.noarch rhscon-core-0.0.6-0.1.alpha1.el7.x86_64 rhscon-ceph-0.0.4-0.1.alpha1.el7.x86_64 How reproducible ================ 100% Steps to Reproduce ================== 1. Install skyring on the server 2. Make sure mongod service is not running: `systemctl stop mongod` 3. Start skyring: `setsid skyring > ~/skyring.log 2>&1` 4. After a while, check /root/skyring.log file note: in step 3, I start skyring daemon process manually because of BZ 1296123 Actual results ============== Skyring process crashes. Also see this excerpt from skyring.log: ~~~ 2016-01-15T15:48:58.925+01:00 INFO main.go:177 start] Starting event listener 2016-01-15T15:50:00.636+01:00 CRITICAL db.go:41 InitDBSession] Error: no reachable servers 2016-01-15T15:50:00.636+01:00 ERROR main.go:188 start] Unable to initialize DB panic: runtime error: invalid memory address or nil pointer dereference [signal 0xb code=0x1 addr=0x0 pc=0x4849b4] ~~~ (full skyring.log file is attached to this BZ) Expected results ================ Skyring process reports the issue in the log without crashing.
Patches: https://review.gerrithub.io/#/c/261493/ https://review.gerrithub.io/#/c/261495/
might be a duplicate of 1299009, at least very similar
(In reply to Jeff Applewhite from comment #3) > might be a duplicate of 1299009, at least very similar Yes, both issues are similar. That said, from my point of view, I saw 2 issues which made skyring crash. Even if both issues were fixed by a single patch, during verification I need to test 2 different scenarios (one for this BZ and 2nd for the other one).
right - ok
I stopped mongod.service and make it not start-able and then run skyring.service 2016-07-19T21:17:06.677+02:00 WARNING monitoring.go:269 FetchStatFromGraphiteWithErrorIndicate] skyring:13fa20d1-cc8f-452c-88bd-a5f284e0b9db - Error Failed to get the instant stat of ping.ping-dhcp46-15_lab_eng_blr_redhat_com resource of dhcp46-27_lab_eng_blr_redhat_com 2016-07-19T21:17:42.687+02:00 INFO main.go:251 func·005] Signal:%!(EXTRA syscall.Signal=terminated) 2016-07-19T21:32:24.236+02:00 CRITICAL db.go:41 InitDBSession] Error: no reachable servers 2016-07-19T21:32:24.244+02:00 ERROR skyring.go:517 InitializeApplication] Unable to initialize DB 2016-07-19T21:32:24.244+02:00 CRITICAL main.go:210 start] Unable to initialize the application. err: no reachable servers No null pointer crash anymore.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2016:1754