Bug 1299907 - Review Request: php-pecl-pq - PostgreSQL client library (libpq) binding
Summary: Review Request: php-pecl-pq - PostgreSQL client library (libpq) binding
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-19 14:17 UTC by Remi Collet
Modified: 2016-03-29 17:57 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-20 20:20:51 UTC
Type: ---
Embargoed:
shawn: fedora-review+


Attachments (Terms of Use)
fedora-review.txt (9.44 KB, text/plain)
2016-03-11 12:38 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2016-01-19 14:17:00 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/d70d87c4b91df81796ae73c5fe114b4cd4d29a9b/php/pecl/php-pecl-pq/php-pecl-pq.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-pecl-pq-1.0.0-2.remi.src.rpm
Description: 
PostgreSQL client library (libpq) binding.

Documents: http://devel-m6w6.rhcloud.com/mdref/pq

Highlights:
* Nearly complete support for asynchronous usage
* Extended type support by pg_type
* Fetching simple multi-dimensional array maps
* Working Gateway implementation


Fedora Account System Username: remi

Comment 1 Shawn Iwinski 2016-03-11 12:38:25 UTC
Created attachment 1135217 [details]
fedora-review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1299907
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 2 Shawn Iwinski 2016-03-11 12:40:06 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import



[!]: Latest version is packaged.

     Latest version is 2.0.0 but packager can decide what their app stack needs.



No blockers.

==== APPROVED =====

Comment 3 Remi Collet 2016-03-11 13:43:56 UTC
>  Latest version is 2.0.0 but packager can decide what their app stack needs.

Version 2.0.0 is for PHP 7 ;)

Thanks for the review.
SCM request open

Comment 4 Gwyn Ciesla 2016-03-11 16:15:36 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-pecl-pq

Comment 5 Fedora Update System 2016-03-11 17:36:01 UTC
php-pecl-pq-1.0.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0c4f000b0d

Comment 6 Fedora Update System 2016-03-11 17:36:07 UTC
php-pecl-pq-1.0.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8ff1d03eb3

Comment 7 Fedora Update System 2016-03-11 17:36:11 UTC
php-pecl-pq-1.0.0-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f78676affb

Comment 8 Fedora Update System 2016-03-11 17:36:15 UTC
php-pecl-pq-1.0.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-87b1373ab1

Comment 9 Fedora Update System 2016-03-11 19:25:04 UTC
php-pecl-pq-1.0.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8ff1d03eb3

Comment 10 Fedora Update System 2016-03-12 16:52:49 UTC
php-pecl-pq-1.0.0-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f78676affb

Comment 11 Fedora Update System 2016-03-12 17:24:50 UTC
php-pecl-pq-1.0.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0c4f000b0d

Comment 12 Fedora Update System 2016-03-12 20:50:24 UTC
php-pecl-pq-1.0.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-87b1373ab1

Comment 13 Fedora Update System 2016-03-20 20:20:49 UTC
php-pecl-pq-1.0.0-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2016-03-21 01:51:43 UTC
php-pecl-pq-1.0.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2016-03-26 18:11:38 UTC
php-pecl-pq-1.0.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2016-03-29 17:57:26 UTC
php-pecl-pq-1.0.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.