Red Hat Bugzilla – Bug 130003
Refactor user edit actions
Last modified: 2007-04-18 13:10:26 EDT
Currently the user pages require that there be a requestScope user
bound to the "targetuser" key. This is done in RhnHelper.getTargetUser().
1) getTargetUser() should see if the user in the request already
matches given uid, if so, don't bother asking DB.
2) get user from db if it is either not the same or non-existent in
3) requires ALL user edit actions to make a call to RhnHelper to get
the target user set. If you forget it the user won't get bound
Proposed solution is to make a BaseUserAction which all user related
actions extend which does this for free. But then again, this uses
Ok, I was on something when I wrote this. I just went through the
action classes and it doesn't make any sense to refactor out the call
to RhnHelper.getTargetUser() since that will simply be replaced by
another one line call.
Also, getTargetUser() is meant to get the user for the given UID and
not the currently logged in user, so no caching.
So I'm closing this bug because there's nothing to do.