Bug 1300195 - improve atomic stop performance
improve atomic stop performance
Status: CLOSED NOTABUG
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: atomic (Show other bugs)
7.4
x86_64 Linux
medium Severity medium
: rc
: ---
Assigned To: Lokesh Mandvekar
atomic-bugs@redhat.com
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-20 03:51 EST by Alex Jia
Modified: 2016-01-27 22:27 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-01-27 22:27:05 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Alex Jia 2016-01-20 03:51:19 EST
Description of problem:
To stop a running container using docker kill and atomic stop command, which will take 10 times real time than docker kill.

Version-Release number of selected component (if applicable):
# rpm -q docker atomic
docker-1.9.1-11.el7.x86_64
atomic-1.8-2.gita35ae18.el7.x86_64


How reproducible:
always

Steps to Reproduce:
1. atomic run rhel7/rhel-tools
2. time docker kill <container_id>
3. repeat 1
4. time atomic stop <container_id>

Actual results:

# docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
04e682b4026f        rhel7/rhel-tools    "/usr/bin/bash"     12 days ago         Up 5 seconds                            rhel-tools
# time docker kill 04e682b4026f
04e682b4026f

real	0m0.153s
user	0m0.025s
sys	0m0.007s

# docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
04e682b4026f        rhel7/rhel-tools    "/usr/bin/bash"     12 days ago         Up 2 seconds                            rhel-tools
# time atomic stop 04e682b4026f

real	0m10.266s
user	0m0.105s
sys	0m0.025s

Expected results:
Fix it.

Additional info:
Comment 2 Daniel Walsh 2016-01-27 10:34:22 EST
atomic stop is doing a docker stop not a docker kill.
Comment 3 Daniel Walsh 2016-01-27 10:35:07 EST
Atomic stop/docker stop gives the container time to cleanup, whereas docker kill just kills pid1.
Comment 4 Alex Jia 2016-01-27 22:27:05 EST
(In reply to Daniel Walsh from comment #2)
> atomic stop is doing a docker stop not a docker kill.

Yes, I just double check it, the Atomic stop will call docker.Client.stop method, and there is no big time deviation between atomic stop and docker stop.


[cloud-user@atomic-00 ~]$ time sudo docker stop f86ba0e9290a
f86ba0e9290a

real	0m10.100s
user	0m0.018s
sys	0m0.011s

[cloud-user@atomic-00 ~]$ time sudo atomic stop f86ba0e9290a

real	0m10.614s
user	0m0.435s
sys	0m0.030s

Note You need to log in before you can comment on or make changes to this bug.