Hide Forgot
Description of problem: The format of program version number is different between rhel6 and rhel7 Version-Release number of selected component (if applicable): # rpm -q virt-viewer virt-viewer-2.0-12.el6.x86_64 How reproducible: 100% Steps to Reproduce: 1. rhel6 # remote-viewer -V remote-viewer version 2.0 (OS ID: rhel6) 2. rhel7 # remote-viewer -V remote-viewer version 2.0-6.el7 (OS ID: rhel7) Actual results: The format of program version number is different between rhel6 and rhel7. Expected results: The format in rhel7 is better. Additional info:
Should be a simple matter of diff --git a/virt-viewer.spec b/virt-viewer.spec index 09ed22c..646cb6d 100644 --- a/virt-viewer.spec +++ b/virt-viewer.spec @@ -260,7 +260,7 @@ autoreconf -if %define govirt_arg --with-ovirt %endif -%configure %{spice_arg} %{gtk_arg} %{govirt_arg} --disable-update-mimedb +%configure %{spice_arg} %{gtk_arg} %{govirt_arg} --with-buildid=%{release} --disable-update-mimedb %__make %{?_smp_mflags} More importantly (for improved RHEV integration), we are also lacking --with-osid=rhel%{?rhel}
I think the --with-osid issue should be fixed in 6.8 (the --version issue would have been fine to postpone to 6.9 imo as devel phase is closed). I suggest that we use this bug to address both as the fix is a very similar one-liner in both cases, no need to have 2 different bugs for that.
(In reply to Christophe Fergeau from comment #2) > Should be a simple matter of > diff --git a/virt-viewer.spec b/virt-viewer.spec > index 09ed22c..646cb6d 100644 > --- a/virt-viewer.spec > +++ b/virt-viewer.spec > @@ -260,7 +260,7 @@ autoreconf -if > %define govirt_arg --with-ovirt > %endif > > -%configure %{spice_arg} %{gtk_arg} %{govirt_arg} --disable-update-mimedb > +%configure %{spice_arg} %{gtk_arg} %{govirt_arg} --with-buildid=%{release} > --disable-update-mimedb > %__make %{?_smp_mflags} I will add this to the virt-viewer.spec on the next rhel-6.8 build. > > More importantly (for improved RHEV integration), we are also lacking > --with-osid=rhel%{?rhel} We do have --with-osid=rhel%{?rhel} applied for 6.8 (with all the version info patches). We don't have them for 7.3 though. I'm moving this bug to post.
Ah right, forgot to update my git repository /o\ Given that we are more or less out of development phase, this bug is minor enough for it to be postponed to 6.9. However, if there are more virt-viewer build planned, it's indeed even easier to just fix it at this time.
I can reproduced the bug with build: virt-viewer-2.0-12.el6.x86_64 Try to verify the bug with build: virt-viewer-2.0-13.el6.x86_64 Steps: 1.# rpm -q virt-viewer virt-viewer-2.0-13.el6.x86_64 2.Check "--with-osid" outputs: # remote-viewer -V remote-viewer version 2.0-13.el6 (OS ID: rhel6) Result now: The format of program version number has been fixed as rhel7 So move the bug from ON_QA to VERIFIED
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-0832.html