RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Created attachment 1116893 [details]
[patch] fix command line parsing

I noticed an out of bounds read access in keyctl when compiling it with
address sanitizer (add -fsanitize=address to cflags).

I figured out it was the code for parsing the command line, here:
        for (cmd = commands; cmd->name; cmd++) {
                if (!cmd->action)
                        continue;
                if (strlen(cmd->name) > n)
                        continue;
                if (memcmp(cmd->name, *argv, n) != 0)
                        continue;

The strlen(cmd->name) > n comparison seems wrong, it must be <. Because
when the cmd->name is shorter than argv there never can be a partial
match, if it is larger then there can be. This error causes the memcmp
command to read invalid memory.

(I reported this a while back directly to the maintainer via email, but received no reply. The last release of keyutils was in 2014.)

I noted that a new release of keyutils was published recently, yet this bug is still in there.
It's a pretty obvious bug and a straightforward fix, so I wonder: why?

Hi,

this bug is for RHEL-7 and keyutils were not ever updated there. If you require fix in RHEL-7, you need to contact the regular Red Hat support channels to request it.

What I would suggest is to pursue the fix in fedora/upstream first. Let me know if there is anything I can help you with.

Hi, I actually wanted to report this upstream. This tool is hosted on a redhat webpage [1], so my assumption is this is upstream. Who else should I report it?

[1] https://people.redhat.com/dhowells/keyutils/

After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.