Red Hat Bugzilla – Bug 1300899
Still show "Cancelling" message while the build/deployment has be cancelled
Last modified: 2016-12-09 16:50:50 EST
Description of problem:
Cancel a running build/deployment, then it will show message like "Cancelling build ruby-sample-build-2 of ruby-sample-build". While it has been cancelled, the message should turn to "cancelled" instead of keep "Cancelling".
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Login into web console, create project and new-app containing bc/dc
2. Restart a build, and cancel it, then check the bar message
3. Deploy a deployment, and cancel it, then check the bar message
2. The bar message shows "Cancelling build ruby-sample-build-2 of ruby-sample-build", but after it has been cancelled, the message still shows "Cancelling"
3. Same issue for cancelling deployment
2 and 3, after it has been cancelled, the message should turn to "Cancelled" instead of keeping "Cancelling"
Switching to always say Cancelled since by the time we show the message we know the API request to cancel completed successfully.
Created attachment 1220796 [details]
An error occurred while cancelling the deployment
(In reply to Jessica Forrester from comment #1)
> Switching to always say Cancelled since by the time we show the message we
> know the API request to cancel completed successfully.
FYI, not sure if it will be affected in the situation when cancellation sometimes shows error like:
An error occurred while cancelling the deployment.Operation cannot be fulfilled on replicationcontrollers "hooks-7": the object has been modified; please apply your changes to the latest version and try again
The error messages are worded correctly, we can leave those.
The fix is in https://github.com/openshift/origin-web-console/pull/867
just waiting for everything to open up for 1.5 to merge it
Commit pushed to master at https://github.com/openshift/origin-web-console
Bug 1300899 Switch success messages from saying Cancelling to Cancelled
Checked on openshift v1.4.0-alpha.1+63e3797-264, now cancel running build/deployment it will show a cancelled info, such as "Cancelled build eap-app-3 of eap-app.","Cancelled deployment eap-app-4 of eap-app."
The bug has been fixed, so move it to Verified.