Red Hat Bugzilla – Bug 1301064
remote-viewer is missing icons
Last modified: 2016-08-23 16:48:44 EDT
Created attachment 1117195 [details]
example of missing icon
Description of problem:
Some icons in remote-viewer are missing
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. open remote-viewer
2. under file > usb device selection, select a webcam
3. the image attached as one example
No image, log outputs:
(remote-viewer.exe:8872): Gtk-WARNING **: Error loading theme icon 'dialog-warning' for stock: Icon 'dialog-warning' not present in theme
(remote-viewer.exe:8872): Gtk-WARNING **: Error loading theme icon 'dialog-information' for stock: Icon 'dialog-information' not present in theme
Image and no warnings related to icons
The widget used for USB Redirection is provided by spice-gtk, so the problem is most likely there (kinda) and would be easily fixed by add those missing icons as part of the wxi file for spice-gtk in msitools.
Would you mind checking if this is the only missing icon?
I probably have missed this because for the upstream windows client we don't enable usb redirection.
I don't think the missing icons are related to the usb redirection. They seem to be the default 'dialog-warning' and 'dialog-information' and could be missing in other widgets of virt-viewer.
But so far, those two were the only ones that I see that are missing.
I'm still doing some tests related to Bug 1301088 - If I find other icons, I'll add here.
(In reply to Victor Toso from comment #2)
> Hi Fabiano,
> I don't think the missing icons are related to the usb redirection. They
> seem to be the default 'dialog-warning' and 'dialog-information' and could
> be missing in other widgets of virt-viewer.
They are related to the library who provides the widget.
For instance, usb-device-widget.c is full of STOCK icons. AFAIU, the .wxi file from this library should provide info about all the icons being used. For virt-viewer, for instance, all the icons being used (including the STOCK ones) are provided by "adwaita-icons-needed.wxi".
Another option would be including the whole adwaita theme as gtk dependency, but then any program using GTK will have its size considerably increased because of the icons, which is better to avoid.
A simple test to do (don't bother doing it, I mentioning just for the record) is adding the image relative to the action to the virt-viewer installed folder. Most likely the problem will disappear and then we can know what exactly has been missing.
I'll take a look on this after we drop GTK2 from spice-gtk, then we can also remove these deprecated stock icons usage ...
> But so far, those two were the only ones that I see that are missing.
> I'm still doing some tests related to Bug 1301088 - If I find other icons,
> I'll add here.
Super, thanks for doing this.
I guess the best solution here is to depend on mingw-adaita-icon-theme.
I already opened a bug for branching the package for RHEVM-4.0: https://projects.engineering.redhat.com/browse/RCM-2173
Patch sent upstream:
oVirt 4.0 Alpha has been released, moving to oVirt 4.0 Beta target.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.