Bug 1301147 - Docker CLI parses -- as if it were an argument
Docker CLI parses -- as if it were an argument
Status: CLOSED WONTFIX
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: docker (Show other bugs)
7.2
x86_64 Linux
low Severity low
: rc
: ---
Assigned To: smahajan@redhat.com
atomic-bugs@redhat.com
: Extras, UserExperience, WorkAround
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-22 12:45 EST by Chris Evich
Modified: 2016-02-02 11:29 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-02-02 11:29:35 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Chris Evich 2016-01-22 12:45:35 EST
Description of problem:
Very minor issue, but possibly confusing and may/could cause problems with higher-level tools executing the docker daemon.

Version-Release number of selected component (if applicable):
docker-1.8.2-10.el7.x86_64

How reproducible:
Trivial

Steps to Reproduce:
1. /usr/bin/docker daemon -g fdsafsd -b dsca -s fdsafs -e feae -- --name=flag_cGpa

Actual results:

docker: "daemon" requires 0 arguments.
See '/usr/bin/docker daemon --help'.

Usage:	docker daemon [OPTIONS]

Enable daemon mode

Expected results:
flag provided but not defined: --name
See '/usr/bin/docker daemon --help'.

Additional info:
Docker is parsing the '--' as an argument whereas a vast majority of other CLI's follows GNU usage conventions where '--' signals the end of optional (non-positional) arguments.  For example, if you wanted to pass in a literal '--name=flag_cGpa' as an argument (instead of an option).  Though docker currently doesn't accept positional arguments in 'daemon' mode, it may in the future.  Also tooling which executes docker CLI may use this convention, causing false-failures. Though it could be a stretch, which is why I think this is a minor issue.
Comment 2 Chris Evich 2016-01-22 12:58:47 EST
Covered by automated test: https://github.com/autotest/autotest-docker/tree/master/subtests/docker_cli/negativeusage
Comment 3 Daniel Walsh 2016-01-22 13:41:14 EST
Shishir can you take care of this.
Comment 4 smahajan@redhat.com 2016-02-02 11:29:35 EST
After discussion with Chris, we both agree this is a minor issue.
This does work for `docker run`. however `docker daemon` doesn't treat -- in the correct unix way.

Docker daemon is a delicate area in upstream. and with my past experience it can go into months of discussion (time and effort) for this minor issue, if we open this issue upstream. We can use that time in more meaningful efforts.

Thanks Chris for understanding. I am going to close this one for now.

Shishir

Note You need to log in before you can comment on or make changes to this bug.