Red Hat Bugzilla – Bug 1301353
memory overcommit accepts negative values and sets them to 200%
Last modified: 2016-07-17 03:29:11 EDT
Description of problem:
Memory overcommit should only accept allowed values- 100/150/200% in API, but instead it accepts all values
this is a negative flow
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. create cluster
2. update memory overcommit to value != 100/150/200
Update successfully to wrong value
This is true for all APIs - cli, java, python & rest
Im putting this on medium because Im not sure what is the affect of having not allowed values set
the failing test:
The API doesn't perform any validation on this value. If values other than 100/150/200 should be rejected then the backend should validate that and return the appropriate error message to the API.
This is the expected behavior and works by design.
We allow other positive values using the REST API.
If you can set a negative value, please reopen this BZ.
Indeed we are able to set positive values and in the UI the result is:
Custom Overcommit Threshold - Set to 3% via API/CLI
but when I set any negative value via the API it is set to 200%
(In reply to Nelly Credi from comment #3)
> Indeed we are able to set positive values and in the UI the result is:
> Custom Overcommit Threshold - Set to 3% via API/CLI
> but when I set any negative value via the API it is set to 200%
Thanks. So this is mainly a harmless nit to ensure we either fail or
set the default value (120%).
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
I just want to make sure you don't disable this feature:
in fact we use this to allow for greater overcommits than 200% (which seems just a randomly chosen artificial limit anyway?)
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.
(In reply to Sven Kieske from comment #6)
> I just want to make sure you don't disable this feature:
> in fact we use this to allow for greater overcommits than 200% (which seems
> just a randomly chosen artificial limit anyway?)
Can someone maybe explain why this feature should be removed?
oVirt 4.0 beta has been released, moving to RC milestone.
Since this is mostly harmless I'm closing for capacity reasons.
If someone has a compelling reason to solve it, please reopen with the full explanation. Patches are always welcomed.
Reopening since there's a patch available.
This will be handled for 4.1.
The suggested patch caused a regression.
Closing this as we have more important issues to fix.