Bug 1301812 - Candlepin is failing on updating and importing manifest
Candlepin is failing on updating and importing manifest
Status: CLOSED ERRATA
Product: Red Hat Satellite 6
Classification: Red Hat
Component: Candlepin (Show other bugs)
Unspecified
x86_64 Linux
urgent Severity urgent (vote)
: 6.1.7
: --
Assigned To: satellite6-bugs
Kedar Bidarkar
: Triaged
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-25 21:59 EST by Alexey Masolov
Modified: 2017-02-23 14:38 EST (History)
10 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-02-15 10:52:45 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Comment 1 Pavel Moravec 2016-01-26 03:48:22 EST
"Import attempt completed for owner .." is false positive log - it should be logged after the NPE that occurred sooner.


org.candlepin.controller.CandlepinPoolManager.processPoolUpdates:366:

            Event event = poolEvents.get(existingPool.getId())
                    .setNewEntity(existingPool)
                    .buildEvent();

poolEvents shouldnt be null since the same command passed in previous iteration of "for (PoolUpdate updatedPool : updatedPools) {" .

existingPool should be null since "if (existingPool.isMarkedForDelete()) {" would already raise the NPE

existingPool.getId() should be not null (see previous "Pool changed: " pool id)

setNewEntity does not seem to be able to return null

So I suspect poolEvents.get(..) returning null (also candlepin reported 410 Gone, that supports it).
Comment 2 Pavel Moravec 2016-01-26 03:59:32 EST
(In reply to Pavel Moravec from comment #1)
> So I suspect poolEvents.get(..) returning null (also candlepin reported 410
> Gone, that supports it).

But poolEvents has been filled properly recently:

        Map<String, EventBuilder> poolEvents = new HashMap<String, EventBuilder>();
        for (Pool existing : existingPools) {
            EventBuilder eventBuilder = eventFactory
                    .getEventBuilder(Target.POOL, Type.MODIFIED)
                    .setOldEntity(existing);
            poolEvents.put(existing.getId(), eventBuilder);
        }
..
        return processPoolUpdates(poolEvents, updatedPools);
Comment 9 Kedar Bidarkar 2016-02-05 07:56:09 EST
It seems this bug had to be tested with
a) particular manifest and
b) particular state of CP DB (postgresql)

[xyz@abc .ssh]# systemctl stop tomcat
[xyz@abc .ssh]# su - postgres
-bash-4.2$ dropdb candlepin && createdb candlepin
-bash-4.2$ pg_restore -d candlepin /tmp/candlepin_admin.dump
-bash-4.2$ exit
logout
[xyz@abc ~]# systemctl start tomcat

Create an org temorg 

Uploaded manifest a) to temporg and manifest got successfully imported.

VERIFIED with Sat6.1.7 compose1
Comment 14 errata-xmlrpc 2016-02-15 10:52:45 EST
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2016:0174

Note You need to log in before you can comment on or make changes to this bug.