Bug 1301993 - [RFE] pcs property list/show could have a --node filter
Summary: [RFE] pcs property list/show could have a --node filter
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pcs
Version: 7.4
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Tomas Jelinek
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-26 13:52 UTC by Michele Baldessari
Modified: 2016-11-03 20:56 UTC (History)
7 users (show)

Fixed In Version: pcs-0.9.152-5.el7
Doc Type: Enhancement
Doc Text:
Feature: Be able to list node attributes of specified node. Currently it is only possible to list attributes of all nodes. Reason: Make reading and parsing of the output easier. Result: New command "pcs node attributes" has been implemented which makes it easier to manage node attributes and also allows to display attributes of a specified node.
Clone Of:
Environment:
Last Closed: 2016-11-03 20:56:32 UTC
Target Upstream Version:


Attachments (Terms of Use)
proposed fix (20.34 KB, patch)
2016-07-22 10:10 UTC, Tomas Jelinek
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1302010 0 medium CLOSED pcs property show <property> shows all node properties unfiltered 2021-02-22 00:41:40 UTC
Red Hat Product Errata RHSA-2016:2596 0 normal SHIPPED_LIVE Moderate: pcs security, bug fix, and enhancement update 2016-11-03 12:11:34 UTC

Internal Links: 1302010

Description Michele Baldessari 2016-01-26 13:52:16 UTC
Description of problem:
While adding pcs property support to puppet, I realized it would be nice
to also have a  "pcs list property --node <node>" variant.

That is because we can set properties per --node, so it is nice via a script
to be able to retrieve only the properties for a single node.

For example:
pcs property --node centos
Node Attributes:
 centos: foo=bar

Comment 2 Tomas Jelinek 2016-01-28 11:38:07 UTC
Node properties should be moved to "pcs node" command.

Comment 3 Tomas Jelinek 2016-07-22 10:10:47 UTC
Created attachment 1182769 [details]
proposed fix

Comment 4 Ivan Devat 2016-07-28 19:09:34 UTC
Before Fix:

Command "pcs node attribute" does not exist.
Command "pcs node utilization" does not support --name modifier.


After Fix:
[vm-rhel72-1 ~] $ rpm -q pcs                       
pcs-0.9.152-5.el7.x86_64

1)
[vm-rhel72-1 ~] $ pcs node attribute
Node Attributes:
[vm-rhel72-1 ~] $ pcs node attribute vm-rhel72-3 foo=bar
[vm-rhel72-1 ~] $ pcs node attribute vm-rhel72-3 bar=foo
[vm-rhel72-1 ~] $ pcs node attribute vm-rhel72-1 bar=baz
[vm-rhel72-1 ~] $ pcs node attribute                    
Node Attributes:
 vm-rhel72-1: bar=baz
 vm-rhel72-3: bar=foo foo=bar
[vm-rhel72-1 ~] $ pcs node attribute vm-rhel72-1 
Node Attributes:
 vm-rhel72-1: bar=baz
[vm-rhel72-1 ~] $ pcs node attribute --name=bar 
Node Attributes:
 vm-rhel72-1: bar=baz
 vm-rhel72-3: bar=foo

2)
[vm-rhel72-1 ~] $ pcs node utilization vm-rhel72-1 foo=1  
[vm-rhel72-1 ~] $ pcs node utilization vm-rhel72-1 bar=1
[vm-rhel72-1 ~] $ pcs node utilization vm-rhel72-3 bar=2
[vm-rhel72-1 ~] $ pcs node utilization --name bar       
Node Utilization:
 vm-rhel72-1: bar=1
 vm-rhel72-3: bar=2

Comment 8 errata-xmlrpc 2016-11-03 20:56:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2596.html


Note You need to log in before you can comment on or make changes to this bug.