Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1302386

Summary:	When introspection fails, the failure should be made very visible in stdout
Product:	Red Hat OpenStack	Reporter:	Dan Yasny <dyasny>
Component:	rhosp-director	Assignee:	Dmitry Tantsur <dtantsur>
Status:	CLOSED WONTFIX	QA Contact:	Dan Yasny <dyasny>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	7.0 (Kilo)	CC:	athomas, dtantsur, jcoufal, mburns, rhel-osp-director-maint
Target Milestone:	y3
Target Release:	7.0 (Kilo)
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Known Issue
Doc Text:	Cause: when introspection fails for many nodes, the actual error message might get lost in the output. Consequence: a user might assume that introspection ended successfully, even if it did not. Workaround (if any): a user should carefully read the introspection command output to spot error messages about failed introspection. Result:	Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-12 15:39:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Yasny 2016-01-27 16:54:54 UTC

Description of problem:
A deployment where introspection fails produces a subdued message in one line, which quickly scrolls on, and end in "Discovery completed."

This might be missed by the deployer and he will move on, to an overcloud setup which will fail.

Version-Release number of selected component (if applicable):

openstack-tripleo-heat-templates-0.8.6-112.el7ost.noarch
openstack-tripleo-image-elements-0.9.6-10.el7ost.noarch
openstack-tripleo-common-0.0.1.dev6-5.git49b57eb.el7ost.noarch
openstack-tripleo-puppet-elements-0.0.1-5.el7ost.noarch
openstack-tripleo-0.0.7-0.1.1664e566.el7ost.noarch
instack-undercloud-2.1.2-37.el7ost.noarch
instack-0.0.7-2.el7ost.noarch

[stack@undercloud72 ~]$ rhos-release -v
1.0.25

How reproducible:
always

Steps to Reproduce:
1. run instrospection where one of the nodes will fail
2. watch stdout
3.

Actual results:

Setting available nodes to manageable...
Starting introspection of node: e06fc6e3-d90d-4a8d-8ef8-748f33edf975
...
Waiting for discovery to finish...
Discovery for UUID e06fc6e3-d90d-4a8d-8ef8-748f33edf975 finished successfully.
...
Setting manageable nodes to available...
Node e06fc6e3-d90d-4a8d-8ef8-748f33edf975 has been set to available.
...
Discovery completed.

If a fault shows up somewhere in the middle, and there are many nodes, the error can only be seen when checking the status or scrolling back over the stdout.

Expected results:
Either output the full ironic status after introspection, or if there had been any errors, throw them into stdout after "Discovery completed." for better user visibility

Additional info:

Comment 2 Dan Yasny 2016-01-27 16:57:05 UTC

This might also be solved by stressing the need to verify the introspection results in the docs, though it will be a better UX if we alert on failures as well.

Comment 3 Angus Thomas 2016-01-28 11:41:28 UTC

Hi Dmitry, Can we get any simple changes to the output in time for 7.3? 

Either way, an update to the docs would make sense,

Comment 4 Dmitry Tantsur 2016-02-02 13:21:55 UTC

Hi, sorry for the late answer. It could be a simple change, but I'm not really fond of making any changes to OSPd7 except for critical fixes.

Comment 5 Jaromir Coufal 2016-02-03 11:21:17 UTC

Dmitry, can you please doc_text this for 7.3 please?

Comment 6 Dmitry Tantsur 2016-02-03 11:24:49 UTC

Done (no clues what to put in the "result" field)

Comment 7 Dan Yasny 2016-02-03 13:50:23 UTC

Ifwe're going for a doc change, I'd say tell the user to run ironic node-list and verify node statuses are as expected post-introspection