Spec URL: https://github.com/runcom/fedora-pkgs/blob/master/golang-github-vbatts-tar-split/fedora/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split.spec SRPM URL: https://github.com/runcom/fedora-pkgs/raw/master/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split-0.9.11-1.fc23.src.rpm Koji builds: - f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12715095 - rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12715092 Description: Pristinely disassembling a tar archive, and stashing needed raw bytes and offsets to reassemble a validating original archive. Fedora Account System Username: runcom Additional information: this is just providing the devel package for v0.9.11
This is missing cmd/ command directory which needs to be packaged as well - so tar-split provides a cmd/ and devel.
spec and SRPM updated Spec URL: https://raw.githubusercontent.com/runcom/fedora-pkgs/master/golang-github-vbatts-tar-split/fedora/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split.spec SRPM URL: https://github.com/runcom/fedora-pkgs/raw/master/golang-github-vbatts-tar-split/fedora/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split-0.9.11-1.fc23.src.rpm Koji builds: - f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12738989 - rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12738992
Updated package to v0.9.12 spec and SRPM updated Spec URL: https://raw.githubusercontent.com/runcom/fedora-pkgs/master/golang-github-vbatts-tar-split/fedora/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split.spec SRPM URL: https://github.com/runcom/fedora-pkgs/raw/master/golang-github-vbatts-tar-split/fedora/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split-0.9.12-1.fc23.src.rpm Koji builds: - f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12755197 - rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12755203
Can you create PR with your spec file and srpm here [1]? Github allows us to comment each line of a spec file. So we don't have to comment affected lines here and get confused what does it actually means. Steps: 1) create directory with expected package name 2) create spec file (with patches and other important files) and srpm in that directory 3) create PR. 4) post link to the PR here. In future, I would like to recommend using Github for golang related comments. [1] https://github.com/gofed/reviews
https://github.com/gofed/reviews/pull/1
$ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-github-vbatts-tar-split-0.9.12-1.fc20.src.rpm golang-github-vbatts-tar-split.src: W: spelling-error Summary(en_US) disassembly -> disassemble, dis assembly, dis-assembly golang-github-vbatts-tar-split.src: W: summary-not-capitalized C tar archive assembly/disassembly golang-github-vbatts-tar-split.src: W: spelling-error %description -l en_US Pristinely -> Pristine golang-github-vbatts-tar-split.src: E: description-line-too-long C Pristinely disassembling a tar archive, and stashing needed raw bytes and offsets to reassemble a validating original archive. golang-github-vbatts-tar-split.src: W: invalid-license BSD 3-clause 1 packages and 0 specfiles checked; 1 errors, 4 warnings. In summary - license should be "BSD" - capitalize summary - break description into two lines
Summary: - golang side of the spec file fine - license ok - rpmlint ok
Spec URL: https://github.com/gofed/reviews/raw/master/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split.spec SRPM URL: https://github.com/gofed/reviews/raw/master/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split-0.9.12-1.fc23.src.rpm Koji builds: - f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12774264 - rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12774380
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/tar-split
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/golang-github-vbatts-tar-split
This package was approved and imported in repositories, but this review ticket was never closed. I'm closing it now.