Bug 130291 - Support LABEL=* with ReiserFS
Support LABEL=* with ReiserFS
Status: CLOSED DEFERRED
Product: Fedora
Classification: Fedora
Component: anaconda (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Anaconda Maintenance Team
Mike McLean
: FutureFeature
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2004-08-18 16:50 EDT by Japheth Cleaver
Modified: 2007-11-30 17:10 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-03-01 14:21:43 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
A patch to enable reading and writing of labels on ReiserFS (2.27 KB, patch)
2004-08-18 20:43 EDT, Japheth Cleaver
no flags Details | Diff

  None (edit)
Description Japheth Cleaver 2004-08-18 16:50:35 EDT
Description of problem:
Anaconda, although it allows the specification of a filesystem 
as "reiserfs" via kickstart, does not use reiserfstune to set the 
label of the filesystem once it's created. ReiserFS entries in fstab 
are created as /dev/hd*.

Version-Release number of selected component (if applicable):


How reproducible: Every time


Steps to Reproduce:
1. Use kickstart to assign a partition to type "reiserfs"
2. Examine /etc/fstab

  
Actual results:
Entries made as /dev/hda3 (or whatever)

Expected results:
Should use LABELs, similar to how ext3 entries are made.


Additional info:
Bug report coming out of bug #130288

To create a label on a reiserfs filesystem, use "reiserfstune -
l /blah /dev/hdxN"
Comment 1 Jeremy Katz 2004-08-18 17:05:13 EDT
reiserfs isn't really supported (for reasons like this among others).
 If you provide a patch, I'd be happy to add it (note that in addition
to the simple side of adding the labelDevice() method in fsset.py, you
also need to add support for reading the label off of a reiserfs
device in isys/isys.py)
Comment 2 Japheth Cleaver 2004-08-18 20:43:21 EDT
Created attachment 102863 [details]
A patch to enable reading and writing of labels on ReiserFS

Here's a patch that (with luck) will enable support. I'm not a python
programmer, so there might be something horribly wrong with this code. :( But
hopefully this shows one way of doing it.
Comment 3 Japheth Cleaver 2004-08-18 20:45:08 EDT
For example, that should be /usr/sbin/reiserfstune instead 
of /usr/bin/reiserfstune (I think) on line 45.
Comment 4 Jeremy Katz 2004-08-24 16:29:12 EDT
Using reiserfstune for reading the label is very error prone and
likely to break if reiserfstune at all adds labeling or anything of
the sort.  Hence why all of the code for other filesystems reads
directly from the disk.  reiserfs is going to need the same (and thus
research into how the label is stored in a reiserfs superblock,
finding the reiserfs superblock, etc)
Comment 5 Chris Lumens 2005-03-01 14:21:43 EST
Deferring based on Jeremy's comments.

Note You need to log in before you can comment on or make changes to this bug.