Hide Forgot
Description of problem: Anaconda, although it allows the specification of a filesystem as "reiserfs" via kickstart, does not use reiserfstune to set the label of the filesystem once it's created. ReiserFS entries in fstab are created as /dev/hd*. Version-Release number of selected component (if applicable): How reproducible: Every time Steps to Reproduce: 1. Use kickstart to assign a partition to type "reiserfs" 2. Examine /etc/fstab Actual results: Entries made as /dev/hda3 (or whatever) Expected results: Should use LABELs, similar to how ext3 entries are made. Additional info: Bug report coming out of bug #130288 To create a label on a reiserfs filesystem, use "reiserfstune - l /blah /dev/hdxN"
reiserfs isn't really supported (for reasons like this among others). If you provide a patch, I'd be happy to add it (note that in addition to the simple side of adding the labelDevice() method in fsset.py, you also need to add support for reading the label off of a reiserfs device in isys/isys.py)
Created attachment 102863 [details] A patch to enable reading and writing of labels on ReiserFS Here's a patch that (with luck) will enable support. I'm not a python programmer, so there might be something horribly wrong with this code. :( But hopefully this shows one way of doing it.
For example, that should be /usr/sbin/reiserfstune instead of /usr/bin/reiserfstune (I think) on line 45.
Using reiserfstune for reading the label is very error prone and likely to break if reiserfstune at all adds labeling or anything of the sort. Hence why all of the code for other filesystems reads directly from the disk. reiserfs is going to need the same (and thus research into how the label is stored in a reiserfs superblock, finding the reiserfs superblock, etc)
Deferring based on Jeremy's comments.