Bug 1303284 - puppet-firewalld 0.2.2 is incompatible with puppet 4.2.1
puppet-firewalld 0.2.2 is incompatible with puppet 4.2.1
Product: Fedora
Classification: Fedora
Component: puppet-firewalld (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Jiri Popelka
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2016-01-30 02:01 EST by Ed Marshall
Modified: 2016-12-20 13:18 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2016-12-20 13:18:36 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Ed Marshall 2016-01-30 02:01:22 EST
Two problems relating to compatibility issues between puppet and puppet-firewalld:


1. puppet-firewalld has an empty if block in zone.pp, which results in this error on the version of puppet included in Fedora:

Error: This 'if' statement has no effect. A value-producing expression without other effect may only be placed last in a block/sequence at /usr/share/puppet/modules/firewalld/manifests/zone.pp:161:2 on node <nodename>

A quick fix is to simply remove this section at line 161 of /usr/share/puppet/modules/firewalld/manifests/zone.pp:

        if "${rich_rules}" != [] {
                # TODO: assert there's one (and only one of)
                # {service, port, protocol, icmp_block, masquerade, forward_port}
                # (So far I have no idea how to do that)

(Which appears to be what has been done on upstream master.)

2. manifests/configuration.pp and templates/firewalld.conf.erb have a variable named $IPv6_rpfilter, with newer versions of puppet reject with the following error:

Error: Illegal parameter name. The given name 'IPv6_rpfilter' does not conform to the naming rule /^[a-z_]\w*$/ at /usr/share/puppet/modules/firewalld/manifests/configuration.pp:56:2 on node <nodename>

Lowercasing the variable in both the manifest and the template corrects the problem; this appears to be what was done in upstream master as well.
Comment 1 Fedora End Of Life 2016-11-24 10:17:07 EST
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 2 Fedora End Of Life 2016-12-20 13:18:36 EST
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.