Hide Forgot
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/cmst.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/cmst-2016.01.26-0.1gitcfe10e5.fc23.src.rpm Description: Qt GUI for Connman with system tray icon. The program provides graphical user interface to control the connman daemon. The connman daemon must be started as you normally would, this program just interfaces with that daemon. You can see what technologies and services connman has found, and for wifi services an agent is registered to assist in obtaining the information from you necessary to logon the wifi service. Fedora Account System Username: martinkg rpmlint -v cmst.spec ../RPMS/x86_64/cmst-2016.01.26-0.1gitcfe10e5.fc23.x86_64.rpm ../SRPMS/cmst-2016.01.26-0.1gitcfe10e5.fc23.src.rpm cmst.spec: I: checking cmst.spec:39: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 39) cmst.spec: I: checking-url https://github.com/andrew-bibb/cmst/archive/cfe10e5145b17dfd80928e7f6b314f5a98cc279c/cmst-cfe10e5145b17dfd80928e7f6b314f5a98cc279c.tar.gz#/cmst-cfe10e5.tar.gz (timeout 10 seconds) cmst.x86_64: I: checking cmst.x86_64: W: spelling-error Summary(en_US) systemtray -> system tray, system-tray, systematic cmst.x86_64: W: spelling-error %description -l en_US wifi -> wife, wiki, WiFi cmst.x86_64: W: spelling-error %description -l en_US logon -> login, logo, loon cmst.x86_64: I: checking-url https://github.com/andrew-bibb/cmst (timeout 10 seconds) cmst.src: I: checking cmst.src: W: spelling-error Summary(en_US) connman -> conman, Conan cmst.src: W: spelling-error Summary(en_US) systemtray -> system tray, system-tray, systematic cmst.src: W: spelling-error %description -l en_US connman -> conman, Conan cmst.src: W: spelling-error %description -l en_US wifi -> wife, wiki, WiFi cmst.src: W: spelling-error %description -l en_US logon -> login, logo, loon cmst.src: I: checking-url https://github.com/andrew-bibb/cmst (timeout 10 seconds) cmst.src:39: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 39) cmst.src: I: checking-url https://github.com/andrew-bibb/cmst/archive/cfe10e5145b17dfd80928e7f6b314f5a98cc279c/cmst-cfe10e5145b17dfd80928e7f6b314f5a98cc279c.tar.gz#/cmst-cfe10e5.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 10 warnings.
- Is this a pre-release? If yes, Release tag is not good. - With this line: %{_datadir}/%{name}/ your package owns all files/sub-directories under /usr/share/cmst, so these %{_datadir}/cmst/autostart/cmst-autostart.desktop %{_datadir}/%{name}/languages/*qm are not need anymore. - Handling locale files with %find_lang. http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files - Why not an appdata file?
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/cmst.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/cmst-2016.01.26-1.git16ee823.fc24.src.rpm %changelog * Wed Feb 24 2016 Martin Gansser <martinkg> - 2016.01.26-1.git16ee823 - changed release tag - removed owned files in files/sub-directories - added %%find_lang macro to find .qm files
(In reply to MartinKG from comment #2) > Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/cmst.spec > SRPM URL: > https://martinkg.fedorapeople.org/Review/SRPMS/cmst-2016.01.26-1.git16ee823. > fc24.src.rpm > > %changelog > * Wed Feb 24 2016 Martin Gansser <martinkg> - > 2016.01.26-1.git16ee823 > - changed release tag > - removed owned files in files/sub-directories > - added %%find_lang macro to find .qm files Please, add a simple appdata file or submitt a request to upstream.
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/cmst.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/cmst-2016.01.26-3.git16ee823.fc24.src.rpm %changelog * Wed Feb 24 2016 Martin Gansser <martinkg> - 2016.01.26-3.git16ee823 - addedd cmst.appdata.xml file
Rawhide build failed: lrelease-qt5: command not found
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/cmst.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/cmst-2016.01.26-4.git16ee823.fc24.src.rpm %changelog * Thu Feb 25 2016 Martin Gansser <martinkg> - 2016.01.26-4.git16ee823 - added %%{_bindir} path to find lrelease-qt5
added correct changelog: %changelog * Thu Feb 25 2016 Martin Gansser <martinkg> - 2016.01.26-4.git16ee823 - added BR qt5-linguist - added BR libappstream-glib
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed == Issues == - Some directories are not owned by the package. Use %{_libexecdir}/%{name}/ %{_datadir}/%{name}/ and remove %{_libexecdir}/%{name}/cmstroothelper %dir %{_datadir}/%{name}/ %{_datadir}/%{name}/autostart/cmst-autostart.desktop - Please, fix spurious-executable-perm warnings ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 41 files have unknown license. Detailed output of licensecheck in /home/sagitter/FedoraReview/1303331-cmst/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/icons/hicolor/20x20/apps, /usr/share/icons/hicolor/20x20, /usr/libexec/cmst, /etc/dbus-1/system.d, /usr/share/cmst/languages, /usr/share/cmst/autostart, /usr/share/icons/hicolor/384x384, /usr/share/icons/hicolor/384x384/apps [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/384x384/apps, /usr/share/icons/hicolor/20x20, /usr/share/icons/hicolor/40x40, /usr/share/icons/hicolor/40x40/apps, /usr/share/icons/hicolor/20x20/apps, /usr/share/cmst/autostart, /etc/dbus-1/system.d, /usr/share/icons/hicolor/384x384, /usr/share/cmst/languages, /usr/libexec/cmst [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in cmst [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cmst- debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2181120 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cmst-2016.01.26-4.git16ee823.fc24.x86_64.rpm cmst-debuginfo-2016.01.26-4.git16ee823.fc24.x86_64.rpm cmst-2016.01.26-4.git16ee823.fc24.src.rpm cmst.x86_64: W: spelling-error Summary(en_US) systemtray -> system tray, system-tray, systematic cmst.x86_64: W: spelling-error %description -l en_US wifi -> wife, wiki, WiFi cmst.x86_64: W: spelling-error %description -l en_US logon -> login, logo, loon cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/main.cpp cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/scrollbox/scrollbox.h cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/control_box/controlbox.cpp cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/scrollbox/scrollbox.cpp cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/control_box/controlbox.h cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/resource.h cmst.src: W: spelling-error Summary(en_US) connman -> conman, Conan cmst.src: W: spelling-error Summary(en_US) systemtray -> system tray, system-tray, systematic cmst.src: W: spelling-error %description -l en_US connman -> conman, Conan cmst.src: W: spelling-error %description -l en_US wifi -> wife, wiki, WiFi cmst.src: W: spelling-error %description -l en_US logon -> login, logo, loon 3 packages and 0 specfiles checked; 0 errors, 14 warnings. Rpmlint (debuginfo) ------------------- Checking: cmst-debuginfo-2016.01.26-4.git16ee823.fc24.x86_64.rpm cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/control_box/controlbox.h cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/resource.h cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/scrollbox/scrollbox.h cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/scrollbox/scrollbox.cpp cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/main.cpp cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/control_box/controlbox.cpp 1 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/scrollbox/scrollbox.cpp cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/control_box/controlbox.h cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/control_box/controlbox.cpp cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/resource.h cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/main.cpp cmst-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9/apps/cmstapp/code/scrollbox/scrollbox.h cmst.x86_64: W: spelling-error Summary(en_US) systemtray -> system tray, system-tray, systematic cmst.x86_64: W: spelling-error %description -l en_US wifi -> wife, wiki, WiFi cmst.x86_64: W: spelling-error %description -l en_US logon -> login, logo, loon 2 packages and 0 specfiles checked; 0 errors, 9 warnings. Requires -------- cmst-debuginfo (rpmlib, GLIBC filtered): cmst (rpmlib, GLIBC filtered): /bin/sh config(cmst) connman hicolor-icon-theme libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.6)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) shadow-utils systemd-units Provides -------- cmst-debuginfo: cmst-debuginfo cmst-debuginfo(x86-64) cmst: appdata() appdata(cmst.appdata.xml) application() application(cmst.desktop) cmst cmst(x86-64) config(cmst) Source checksums ---------------- https://github.com/andrew-bibb/cmst/archive/16ee823c3edb0d91203ac2a532220dc79018b0c9/cmst-16ee823c3edb0d91203ac2a532220dc79018b0c9.tar.gz#/cmst-16ee823.tar.gz : CHECKSUM(SHA256) this package : 4f7277958fbb406aabae2c91e7e5ef0d377f6c192be12d3aaa438bee3ff3f5d1 CHECKSUM(SHA256) upstream package : 4f7277958fbb406aabae2c91e7e5ef0d377f6c192be12d3aaa438bee3ff3f5d1 Generated by fedora-review 0.6.0 (7737a2a) last change: 2015-11-26 Command line :./try-fedora-review -m fedora-rawhide-x86_64 -b 1303331 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/cmst.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/cmst-2016.01.26-5.git16ee823.fc24.src.rpm %changelog * Thu Feb 25 2016 Martin Gansser <martinkg> - 2016.01.26-5.git16ee823 - set correct file permisson - take ownership of unowned directorys
Package approved.
@Antonio thanks for the review.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/cmst
package has been built successfully on fc23, fc24 and rawhide.