Description of problem: Seen during hackathon we weren't validating comma in IP Address Steps to Reproduce: 1. Test from ISO install 2. Enter in IP Address as 192,168.155.10 3. See lack of error validation. 4. Proceeding will break system
https://github.com/fusor/fusor-installer/pull/53 will fix this
RHEL-OSP nodes setup restrictions
Addressed in TP3 RC3
With the changes from https://github.com/fusor/fusor-installer/pull/53 , validate_ntp_host in /usr/share/katello-installer/hooks/lib/provisioning_wizard.rb looks like this: --- def validate_ntp_host if @ntp_host.nil? || @ntp_host.empty? 'NTP sync host must be specified' elsif !(valid_hostname?(@ntp_host)) && !(valid_hostname?(@ntp_host)) 'NTP sync host - Invalid Hostname or IP address' end end --- What's the reason for having !(valid_hostname?(@ntp_host)) && !(valid_hostname?(@ntp_host)) instead of just !(valid_hostname?(@ntp_host)) ? Maybe it was intended to be: !(valid_ip?(@ntp_host)) || !(valid_hostname?(@ntp_host)) ?
This is what was meant. It should be possible to enter an IP or hostname for the ntp host. !(valid_ip?(@ntp_host)) || !(valid_hostname?(@ntp_host))
Shouldn't it be: !(valid_ip?(@ntp_host)) && !(valid_hostname?(@ntp_host)) i.e., if (not a valid ip address) AND (not a valid hostname), then return ''NTP sync host - Invalid Hostname or IP address'?
Yes. I think we're saying the same thing; it's a bug and should be fixed. Working on it now
Verified on fusor-installer-0.0.14-40.el7_2.noarch.rpm
https://github.com/fusor/fusor-installer/pull/55
QCI has sunset. Closing the BZ's.