Bug 1304784 - REST API: Unable to delete custom properties from NIC with old SN API
Summary: REST API: Unable to delete custom properties from NIC with old SN API
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 3.6.3
Hardware: x86_64
OS: Linux
high
high
Target Milestone: ovirt-3.6.3
: 3.6.3.2
Assignee: Martin Mucha
QA Contact: Meni Yakove
URL:
Whiteboard: network
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-04 15:41 UTC by GenadiC
Modified: 2016-02-18 11:18 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-02-18 11:18:51 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-3.6.z+
rule-engine: blocker+
ylavi: planning_ack+
danken: devel_ack+
myakove: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 53314 0 master MERGED core: custom parameters couldn't be updated and wasnt reported 2016-02-16 10:11:58 UTC
oVirt gerrit 53415 0 master MERGED restapi: custom parameters couldn't be updated and wasnt reported 2016-02-16 10:12:48 UTC
oVirt gerrit 53573 0 ovirt-engine-3.6 MERGED core: custom parameters couldn't be updated and wasnt reported 2016-02-16 11:56:26 UTC
oVirt gerrit 53574 0 ovirt-engine-3.6 MERGED restapi: custom parameters couldn't be updated and wasnt reported 2016-02-16 11:57:58 UTC
oVirt gerrit 53575 0 ovirt-engine-3.6.3 MERGED core: custom parameters couldn't be updated and wasnt reported 2016-02-16 11:59:43 UTC
oVirt gerrit 53576 0 ovirt-engine-3.6.3 MERGED restapi: custom parameters couldn't be updated and wasnt reported 2016-02-16 12:04:12 UTC

Description GenadiC 2016-02-04 15:41:28 UTC
Description of problem:
Trying to clear eth_tools and bridge tools with rest API fails

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1.Put ethtool_opts and bridge_opts with some values on the network on host NIC
2.Send to url url:/ovirt-engine/api/hosts/<id>/nics/setupnetworks the body in Additional info
3.

Actual results:
Cleaning custom properties doesn't work (The values of custom properties remain the same)

Expected results:
Cleaning custom properties should succeed

Additional info:
body:<action>
    <async>false</async>
    <grace_period>
        <expiry>10</expiry>
    </grace_period>
    <host_nics>
        <host_nic href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/f76ef727-7672-474a-9451-0719a3e35d26" id="f76ef727-7672-474a-9451-0719a3e35d26">
            <actions>
                <link href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/f76ef727-7672-474a-9451-0719a3e35d26/attach" rel="attach"/>
                <link href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/f76ef727-7672-474a-9451-0719a3e35d26/detach" rel="detach"/>
            </actions>
            <name>enp1s0f1</name>
            <link href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/f76ef727-7672-474a-9451-0719a3e35d26/statistics" rel="statistics"/>
            <link href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/f76ef727-7672-474a-9451-0719a3e35d26/labels" rel="labels"/>
            <link href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/f76ef727-7672-474a-9451-0719a3e35d26/networkattachments" rel="networkattachments
"/>
            <host href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e" id="ab63d2d6-d35e-4c85-ac02-62df95ab8f0e"/>
            <network href="/ovirt-engine/api/networks/55996199-eedf-451b-8fc0-a990fe1a7467" id="55996199-eedf-451b-8fc0-a990fe1a7467"/>
            <mac address="00:25:90:c6:d9:83"/>
            <ip netmask="" gateway="" address=""/>
            <boot_protocol>none</boot_protocol>
            <speed>1000000000</speed>
            <status>
                <state>up</state>
            </status>
            <mtu>1500</mtu>
            <bridged>true</bridged>
            <custom_configuration>false</custom_configuration>
            <properties/>
        </host_nic>
        <host_nic href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/76495e53-9bc1-42e8-9a66-e05e7838e808" id="76495e53-9bc1-42e8-9a66-e05e7838e808">
            <actions>
                <link href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/76495e53-9bc1-42e8-9a66-e05e7838e808/attach" rel="attach"/>
                <link href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/76495e53-9bc1-42e8-9a66-e05e7838e808/detach" rel="detach"/>
            </actions>
            <name>enp1s0f0</name>
            <link href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/76495e53-9bc1-42e8-9a66-e05e7838e808/statistics" rel="statistics"/>
            <link href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/76495e53-9bc1-42e8-9a66-e05e7838e808/labels" rel="labels"/>
            <link href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e/nics/76495e53-9bc1-42e8-9a66-e05e7838e808/networkattachments" rel="networkattachments"/>
            <host href="/ovirt-engine/api/hosts/ab63d2d6-d35e-4c85-ac02-62df95ab8f0e" id="ab63d2d6-d35e-4c85-ac02-62df95ab8f0e"/>
            <network href="/ovirt-engine/api/networks/3399f93b-e62d-4328-99a0-94041fa02550" id="3399f93b-e62d-4328-99a0-94041fa02550"/>
            <mac address="00:25:90:c6:d9:82"/>
            <ip netmask="255.255.255.0" gateway="10.35.128.254" address="10.35.128.24"/>
            <boot_protocol>dhcp</boot_protocol>
            <speed>1000000000</speed>
            <status>
                <state>up</state>
            </status>
            <mtu>1500</mtu>
            <bridged>true</bridged>
            <custom_configuration>false</custom_configuration>
        </host_nic>
    </host_nics>
    <check_connectivity>true</check_connectivity>
    <connectivity_timeout>60</connectivity_timeout>
    <force>false</force>
</action>

Comment 1 Yaniv Kaul 2016-02-05 23:07:54 UTC
Is it a regression? Did it work in 3.5?
(not sure why it's a high severity issue).

Comment 2 GenadiC 2016-02-07 07:09:41 UTC
Regression indeed (adding keyword)

Comment 3 Red Hat Bugzilla Rules Engine 2016-02-07 12:15:23 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 4 Michael Burman 2016-02-18 08:43:35 UTC
Verified on - 3.6.3.2-0.1.el6


Note You need to log in before you can comment on or make changes to this bug.