Bug 1304996 - Review Request: ghc-cmark - Fast, accurate CommonMark (Markdown) parser and renderer
Summary: Review Request: ghc-cmark - Fast, accurate CommonMark (Markdown) parser and r...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Adam Williamson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1095644
TreeView+ depends on / blocked
 
Reported: 2016-02-05 09:26 UTC by Jens Petersen
Modified: 2016-05-20 23:52 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-04-20 19:22:27 UTC
Type: ---
Embargoed:
awilliam: fedora-review+


Attachments (Terms of Use)

Description Jens Petersen 2016-02-05 09:26:42 UTC
Spec URL: http://petersen.fedorapeople.org//ghc-cmark.spec
SRPM URL: http://petersen.fedorapeople.org//ghc-cmark-0.5.1-1.fc23.src.rpm

Description:
This package provides Haskell bindings for <https://github.com/jgm/cmark
libcmark>, the reference parser for <http://commonmark.org CommonMark>, a fully
specified variant of Markdown.

Comment 1 Jens Petersen 2016-02-05 09:40:08 UTC
I had to disable the testsuite on armv7 due to
<https://github.com/jgm/cmark-hs/issues/6>.

This is needed by latest pandoc.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12881418

Comment 2 Adam Williamson 2016-03-03 18:40:44 UTC
...yeah, I just found this whole yak hair thicket...

Comment 3 Adam Williamson 2016-03-03 19:11:56 UTC
rpmlint:

[adamw@adam ghc-cmark]$ rpmlint ./1304996-ghc-cmark/srpm/ghc-cmark.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[adamw@adam ghc-cmark]$ rpmlint 1304996-ghc-cmark/srpm/ghc-cmark-0.5.1-1.fc23.src.rpm 
ghc-cmark.src: W: spelling-error Summary(en_US) renderer -> tenderer, rendered, render er
ghc-cmark.src: W: spelling-error %description -l en_US https -> HTTP
ghc-cmark.src: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub
ghc-cmark.src: W: spelling-error %description -l en_US jgm -> jg, gm, jam
ghc-cmark.src: W: spelling-error %description -l en_US libcmark -> millibar
ghc-cmark.src: W: spelling-error %description -l en_US http -> HTTP
ghc-cmark.src: W: spelling-error %description -l en_US commonmark -> common mark, common-mark, commoner
1 packages and 0 specfiles checked; 0 errors, 7 warnings.

ghc-cmark binary package adds:

ghc-cmark.x86_64: W: no-documentation

that might be nice to fix if any is available. All others are bogus spelling errors, ignore.

Comment 4 Adam Williamson 2016-03-03 19:14:50 UTC
Looks like no-documentation is a red herring, as GHC lib docs go to a different path.

Comment 5 Adam Williamson 2016-03-03 19:17:37 UTC
All review MUST items pass, cmark unbundling looks good, license is correct...package is APPROVED.

Comment 6 Jens Petersen 2016-03-04 01:07:36 UTC
Thank you very much!

Comment 7 Gwyn Ciesla 2016-03-04 12:28:29 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/ghc-cmark

Comment 8 Fedora Update System 2016-03-07 13:15:04 UTC
ghc-cmark-0.5.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6f0af32e54

Comment 9 Fedora Update System 2016-03-07 13:15:11 UTC
ghc-cmark-0.5.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-bd2c5e8b05

Comment 10 Fedora Update System 2016-03-09 21:24:41 UTC
ghc-cmark-0.5.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6f0af32e54

Comment 11 Fedora Update System 2016-03-09 22:57:12 UTC
ghc-cmark-0.5.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-bd2c5e8b05

Comment 12 Fedora Update System 2016-04-20 19:22:24 UTC
ghc-cmark-0.5.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2016-05-20 23:52:43 UTC
ghc-cmark-0.5.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.