Bug 1305302 - Invalid missing-call-to-chdir-with-chroot error for hylafax+
Summary: Invalid missing-call-to-chdir-with-chroot error for hylafax+
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: rpmlint
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-06 21:23 UTC by Lee Howard
Modified: 2016-02-07 19:10 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-02-07 19:10:19 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Lee Howard 2016-02-06 21:23:32 UTC
In F24 (rawhide) rebuild attempts the error:

hylafax+.armv7hl: E: missing-call-to-chdir-with-chroot /usr/sbin/hfaxd

While there may be some convention to doing the chdir() before chroot() doing chdir("/") after chroot() is also valid.  HylaFAX does the latter...

------------------------------
bool isSetup = (chroot(".") >= 0 && chdir("/") >= 0);
------------------------------

The rpmlint check should not throw an error in this case.  Or am I wrong?

Comment 1 Ville Skyttä 2016-02-07 08:12:54 UTC
Which architecture you're running rpmlint on? At least when run on x86_64 against an armv7hl binary, objdump barfs under rpmlint's hood and causes the false positive. That case taken care of in:
https://github.com/rpm-software-management/rpmlint/commit/c5871542684bf1439d96f2430fe4f0010070e4db

Comment 2 Lee Howard 2016-02-07 19:10:19 UTC
Was running on x86_64.  So, I suppose this was already resolved.


Note You need to log in before you can comment on or make changes to this bug.