Bug 1305353 - Make CheckOwnDirs test faster
Make CheckOwnDirs test faster
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: fedora-review (Show other bugs)
23
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Stanislav Ochotnicky
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-07 08:55 EST by Mattias Ellert
Modified: 2016-05-02 15:42 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-05-02 15:42:47 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Mattias Ellert 2016-02-07 08:55:14 EST
Description of problem:

When running fedora-review the time spent performing the CheckOwnDirs test is way too long.

fedora-review -x CheckOwnDirs -m fedora-rawhide-x86_64 -n R-highlight

real	6m16.870s
user	2m28.194s
sys	0m46.464s

fedora-review -m fedora-rawhide-x86_64 -n R-highlight

real	70m38.014s
user	66m8.734s
sys	1m33.922s

I,e, by excluding the CheckOwnDirs test the running time of fedora-review is reduced from 70 minutes to 6 minutes.

Version-Release number of selected component (if applicable):
fedora-review-0.6.0-2.fc23.noarch

How reproducible:
Always

Steps to Reproduce:
1. Compare running fedora-review with and without the -x CheckOwnDirs flag

Actual results:
Excluding the CheckOwnDirs test reduces the running time with about one hour.

Expected results:
This test should not add significantly to the running time of fedora-review

Additional info:

Most of the time is used for running:
dnf repoquery -q -C --requires --resolve <somepackage>

This takes a few minutes per package:

$ time dnf repoquery -q -C --requires --resolve glibc
glibc-0:2.22-7.fc23.i686
glibc-0:2.22-7.fc23.x86_64
glibc-common-0:2.22-7.fc23.x86_64
nss-softokn-freebl-0:3.21.0-1.1.fc23.i686
nss-softokn-freebl-0:3.21.0-1.1.fc23.x86_64

real	3m49.104s
user	3m46.256s
sys	0m2.396s

Without the --resolve flag it returns in less than a second.

So if you could reimplement the test not using the --resolve flag it would be much faster. Or if dnf didn't take that much time when the --resolve flag was used...
Comment 1 Alec Leamas 2016-05-02 15:42:47 EDT
This is basically about bug #1279538. I'm closing this as not-a-bug, which should be understood as not-a-bug in fedora-review but rather dnf.

Thanks for reporting.

Note You need to log in before you can comment on or make changes to this bug.