Bug 1306178 - ovirt-engine-setup-plugin-ovirt-engine does not require ovirt-engine-setup-plugin-vmconsole-proxy-helper
Summary: ovirt-engine-setup-plugin-ovirt-engine does not require ovirt-engine-setup-pl...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Packaging.rpm
Version: ---
Hardware: Unspecified
OS: Unspecified
medium
medium vote
Target Milestone: ovirt-3.6.5
: 3.6.5
Assignee: Rafael Martins
QA Contact: Petr Kubica
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-10 09:05 UTC by Yedidyah Bar David
Modified: 2019-04-28 13:21 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-21 14:41:19 UTC
oVirt Team: Integration
rule-engine: ovirt-3.6.z+
rule-engine: blocker+
ylavi: planning_ack+
sbonazzo: devel_ack+
pstehlik: testing_ack+


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
oVirt gerrit 53339 master MERGED packaging: fix ovirt-engine-setup-plugin-ovirt-engine dependencies 2016-02-11 09:16:01 UTC
oVirt gerrit 53396 ovirt-engine-3.6 MERGED packaging: fix ovirt-engine-setup-plugin-ovirt-engine dependencies 2016-02-11 14:41:37 UTC

Description Yedidyah Bar David 2016-02-10 09:05:23 UTC
Description of problem:

ovirt-engine requires ovirt-engine-vmconsole-proxy-helper

ovirt-engine-vmconsole-proxy-helper requires ovirt-engine-setup-plugin-vmconsole-proxy-helper

This means that on first install of 3.6 (upgrade from 3.5, I think also clean install), user is not asked about this, because the setup-plugin is not installed yet. engine-setup installs it, and if the user then runs again the plugin will be installed and so the user will be asked.

I think ovirt-engine-setup-plugin-ovirt-engine should require ovirt-engine-setup-plugin-vmconsole-proxy-helper.

Thinking about this, it might be a good idea to also require the dwh/reports setup plugins.

Comment 1 Sandro Bonazzola 2016-02-10 09:09:39 UTC
On clean install it should work fine since you install ovirt-engine and it pulls in all the dependencies.

On upgrade, ovirt-engine is under version locking so you're right, the question won't be asked on first round.

Comment 2 Nikolai Sednev 2016-02-10 12:52:24 UTC
(In reply to Yedidyah Bar David from comment #0)
> Description of problem:
> 
> ovirt-engine requires ovirt-engine-vmconsole-proxy-helper
> 
> ovirt-engine-vmconsole-proxy-helper requires
> ovirt-engine-setup-plugin-vmconsole-proxy-helper
> 
> This means that on first install of 3.6 (upgrade from 3.5, I think also
> clean install), user is not asked about this, because the setup-plugin is
> not installed yet. engine-setup installs it, and if the user then runs again
> the plugin will be installed and so the user will be asked.
> 
> I think ovirt-engine-setup-plugin-ovirt-engine should require
> ovirt-engine-setup-plugin-vmconsole-proxy-helper.
> 
> Thinking about this, it might be a good idea to also require the dwh/reports
> setup plugins.

+1.
Regarding the dwh in general, it's an optional package, not required by the engine, same is for the vm-console.
I've first upgraded 3.5->3.6, onle after that I've added vm-console, then re-ran engine-setup again, while already was running on 3.6.

Comment 3 Yaniv Lavi 2016-02-10 13:54:52 UTC
Why are we adding DWH and reports setup to every installation, it should be optional.

Comment 4 Sandro Bonazzola 2016-02-10 14:03:41 UTC
I agree, DWH and reports are optional. Issue here is that ovirt-engine-vmconsole-proxy-helper is not.
Please ignore the DWH and reports part.

Here yum update "ovirt-engine-setup*" (as per docs) will update DWH and reports.
But the above command won't install ovirt-engine-setup-plugin-vmconsole-proxy-helper unless we add the dependency.

Comment 5 Yaniv Lavi 2016-02-10 15:57:48 UTC
(In reply to Sandro Bonazzola from comment #4)
> I agree, DWH and reports are optional. Issue here is that
> ovirt-engine-vmconsole-proxy-helper is not.
> Please ignore the DWH and reports part.
> 
> Here yum update "ovirt-engine-setup*" (as per docs) will update DWH and
> reports.
> But the above command won't install
> ovirt-engine-setup-plugin-vmconsole-proxy-helper unless we add the
> dependency.

Acking just for the vm console package.

Comment 6 Petr Kubica 2016-04-15 12:22:13 UTC
Verified in 3.6.5-4 (update from latest 3.5)

#yum update rhevm-setup
Updating:
 rhevm-setup
Installing for dependencies:
 ovirt-engine-extension-aaa-jdbc
 ovirt-setup-lib
 rhevm-setup-plugin-vmconsole-proxy-helper
Updating for dependencies:
 otopi
 otopi-java
 rhevm-lib
 rhevm-setup-base
 rhevm-setup-plugin-ovirt-engine
 rhevm-setup-plugin-ovirt-engine-common
 rhevm-setup-plugin-websocket-proxy
 rhevm-setup-plugins


Note You need to log in before you can comment on or make changes to this bug.