Bug 1306615 - Review Request: perl-SQL-Interp - Interpolate Perl variables into SQL statements
Review Request: perl-SQL-Interp - Interpolate Perl variables into SQL statements
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Šabata
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-11 08:05 EST by Jitka Plesnikova
Modified: 2016-02-11 11:14 EST (History)
2 users (show)

See Also:
Fixed In Version: perl-SQL-Interp-1.22-1.fc24
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-02-11 11:14:17 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
psabata: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2016-02-11 08:05:16 EST
Spec URL: https://jplesnik.fedorapeople.org/perl-SQL-Interp/perl-SQL-Interp.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-SQL-Interp/perl-SQL-Interp-1.22-1.fc24.src.rpm

Description:
SQL::Interp converts a list of intermixed SQL fragments and variable
references into a conventional SQL string and list of bind values suitable
for passing onto DBI. This simple technique creates database calls that are
simpler to create and easier to read, while still giving you full access to
custom SQL.

Fedora Account System Username: jplesnik@redhat.com
Comment 1 Petr Šabata 2016-02-11 09:01:28 EST
* Missing a buildtime dep:
  - Data::Dumper, used in t/dbi.t, t/lib.pl and t/sql_interp.t
 
* The `perl(DBI.*)' filter is quite dangerous and might cause problems in the
  future if people overlook it.  Perhaps filtering DBI and DBI::db would be
  a better option.

* I see you've already reported RT#111948, good.

* Filter::Simple and Text::Balanced aren't probably needed but since upstream
  lists them in the metadata, I won't consider this an error.


Only the first point really needs fixing.  Do so before building the package.
Approving this now.
Comment 2 Gwyn Ciesla 2016-02-11 10:36:45 EST
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-SQL-Interp
Comment 3 Jitka Plesnikova 2016-02-11 11:14:17 EST
Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.