Spec URL: https://jplesnik.fedorapeople.org/perl-SQL-Interp/perl-SQL-Interp.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-SQL-Interp/perl-SQL-Interp-1.22-1.fc24.src.rpm Description: SQL::Interp converts a list of intermixed SQL fragments and variable references into a conventional SQL string and list of bind values suitable for passing onto DBI. This simple technique creates database calls that are simpler to create and easier to read, while still giving you full access to custom SQL. Fedora Account System Username: jplesnik
* Missing a buildtime dep: - Data::Dumper, used in t/dbi.t, t/lib.pl and t/sql_interp.t * The `perl(DBI.*)' filter is quite dangerous and might cause problems in the future if people overlook it. Perhaps filtering DBI and DBI::db would be a better option. * I see you've already reported RT#111948, good. * Filter::Simple and Text::Balanced aren't probably needed but since upstream lists them in the metadata, I won't consider this an error. Only the first point really needs fixing. Do so before building the package. Approving this now.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-SQL-Interp
Thank you for the review and the repository.