Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1306743

Summary:	Live Merge does not update the database properly upon failure
Product:	[oVirt] ovirt-engine	Reporter:	Greg Padgett <gpadgett>
Component:	BLL.Storage	Assignee:	Liron Aravot <laravot>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Elad <ebenahar>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.0.0	CC:	acanan, ahino, amureini, bugs, ebenahar, laravot, tnisan
Target Milestone:	ovirt-4.0.0-alpha	Flags:	rule-engine: ovirt-4.0.0+ rule-engine: planning_ack+ rule-engine: devel_ack+ acanan: testing_ack+
Target Release:	4.0.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt 4.0.0 alpha1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-07-05 07:47:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Greg Padgett 2016-02-11 17:16:03 UTC

Description of problem:
Discovered while investigating bug 1302215, the master branch code doesn't update the database properly when Live Merge fails.  The images with data merged into it should be illegal; however, it is left as OK.  (I believe this is caused by something outside the immediate live merge code, but could be mistaken as I haven't investigated too deeply.)

This bz is to ensure we don't forget to fix/check this.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Run Live Merge
2. Make it fail
3. Notice the image in the snapshot is OK

Actual results:
Image is OK

Expected results:
Image is illegal

Additional info:

Comment 1 Allon Mureinik 2016-02-14 13:27:07 UTC

This bug does not reproduce on the 3.6.z branch, pushing out to 4.0, where it (of course) needs to be fixed.

Comment 2 Allon Mureinik 2016-02-16 17:10:11 UTC

(In reply to Allon Mureinik from comment #1)
> This bug does not reproduce on the 3.6.z branch, pushing out to 4.0, where
> it (of course) needs to be fixed.
Liron/Ala - based on recent conversations, I am not sure this statement is correct.

Could you either confirm or refute (in which case, this BZ probably needs to be retargeted to 3.6.3.*).

Comment 3 Liron Aravot 2016-02-17 08:05:50 UTC

Allon, this bug is relevant to v4.0.

Comment 4 Elad 2016-04-19 13:32:31 UTC

After a failed live merge, the snapshot disk (volume) is marked as illegal.

1caae771ff' images '94db6296-3480-40ff-a3eb-1f7f62e6ca1c'..'8dd4dbb2-7eba-42fe-b846-40036ad34869' merged, but volume removal failed. Some or all of the following volumes may be orphaned:
 [94db6296-3480-40ff-a3eb-1f7f62e6ca1c]. Please retry Live Merge on the snapshot to complete the operation


<disk_snapshots>
<disk_snapshot href= "/ovirt-engine/api/storagedomains/6ba7f20b-4209-4909-b67f-a7590fa45081/disksnapshots/94db6296-3480-40ff-a3eb-1f7f62e6ca1c" id="94db6296-3480-40ff-a3eb-1f7f62e6ca1c">
...
<state>illegal</state>
...

Verified using:
ovirt-engine-4.0.0-0.0.master.20160406161747.gita4ecba2.el7.centos.noarch
vdsm-4.17.999-724.gitb8cb30a.el7.centos.noarch

Comment 6 Sandro Bonazzola 2016-07-05 07:47:23 UTC

oVirt 4.0.0 has been released, closing current release.